Re: Patch to not create GOT and dynamic relocation entries for unresolved symbols with --warn-unresolved-symbols.

[Sriraman Tallam <tmsriram at google dot com>]

On Thu, Apr 23, 2015 at 8:09 AM, Cary Coutant <ccoutant@gmail.com> wrote:
>> +      // If --weak-unresolved-symbols is set, change binding of unresolved
>> +      // global symbols to STB_WEAK.
>> +      if (parameters->options().weak_unresolved_symbols()
>> +         && (binding == elfcpp::STB_GLOBAL
>> +             || binding == elfcpp::STB_LOCAL)
>>
>> Why check for STB_LOCAL? Local symbols can't be unresolved. What about
>> STB_GNU_UNIQUE symbols? (Perhaps that's what you meant.)
>
> On further thought, I doubt we will see an undefined GNU_UNIQUE
> symbol, and if we do, I'm not sure we should be changing it to WEAK
> (unless the very next if statement converts it to GLOBAL).

Patch redone and attached.

Thanks
Sri

>
> -cary

Attachment: weak_unresolved_symbols_patch.txt
Description: Text document