This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH][GAS][AARCH64]Fix "align directive causes MAP_DATA symbol to be lost"

From: Renlin Li <renlin dot li at arm dot com>
To: Marcus Shawcroft <marcus dot shawcroft at gmail dot com>
Cc: "binutils at sourceware dot org" <binutils at sourceware dot org>, "nickc at redhat dot com" <nickc at redhat dot com>, Marcus Shawcroft <Marcus dot Shawcroft at arm dot com>
Date: Thu, 26 Mar 2015 11:03:06 +0000
Subject: Re: [PATCH][GAS][AARCH64]Fix "align directive causes MAP_DATA symbol to be lost"
Authentication-results: sourceware.org; auth=none
References: <5511A0E4 dot 8020802 at arm dot com> <5512A987 dot 2000404 at redhat dot com> <CAFqB+Pz97Ysuz==AbbLn5jNPnTb1CPxFZX0-b-AQDzWkdbJD-A at mail dot gmail dot com>

Hi Marcus,

After the change, we emit MAP_DATA symbols even there is no instructionin .text section.

So we have got one more data symbol for bintest.s test case.

I will double check and find a solution.

Regards,
Renlin

On 26/03/15 09:29, Marcus Shawcroft wrote:

On 25 March 2015 at 12:26, Nicholas Clifton <nickc@redhat.com<mailto:nickc@redhat.com>> wrote:


    Hi Renlin,

        gas/ChangeLog:

        2015-03-24  Renlin Li  <renlin.li@arm.com
        <mailto:renlin.li@arm.com>>

             * config/tc-aarch64.c (mapping_state): Remove first MAP_DATA
        emitting code.
             (mapping_state_2): Emit first MAP_DATA symbol here.


    Approved - please apply.

    Cheers
      Nick

This patch appears to causes the following two regressions foraarch64-none-linux-gnu:

FAIL: readelf -S
FAIL: readelf -s

Cheers
/Marcus

Follow-Ups:
- Re: [PATCH][GAS][AARCH64]Fix "align directive causes MAP_DATA symbol to be lost"
  - From: Marcus Shawcroft
- [PATCH][AARCH64]Fix bintest.s failure after "Fix align directive causes MAP_DATA symbol to be lost" change
  - From: Renlin Li

References:
- [PATCH][GAS][AARCH64]Fix "align directive causes MAP_DATA symbol to be lost"
  - From: Renlin Li
- Re: [PATCH][GAS][AARCH64]Fix "align directive causes MAP_DATA symbol to be lost"
  - From: Nicholas Clifton

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]