This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [Committed][AArch64] Factor out _bfd_aarch64_resize_stubs()
- From: Marcus Shawcroft <marcus dot shawcroft at arm dot com>
- To: "binutils at sourceware dot org" <binutils at sourceware dot org>
- Date: Mon, 23 Mar 2015 16:44:34 +0000
- Subject: Re: [Committed][AArch64] Factor out _bfd_aarch64_resize_stubs()
- Authentication-results: sourceware.org; auth=none
- References: <551042C2 dot 4030504 at arm dot com>
On 23/03/15 16:43, Marcus Shawcroft wrote:
Factor out stub section resizing into a standalone function. No
functional change. Committed.
/Marcus
2015-03-23 Marcus Shawcroft <marcus.shawcroft@arm.com>
* elfnn-aarch64.c (elfNN_aarch64_size_stubs): Factor out
stub resize code into...
(bfd_aarch64_resize_stubs): Define.
.. and this time with the patch...
diff --git a/bfd/elfnn-aarch64.c b/bfd/elfnn-aarch64.c
index 5f80a2d..d5a64b5 100644
--- a/bfd/elfnn-aarch64.c
+++ b/bfd/elfnn-aarch64.c
@@ -3118,6 +3118,29 @@ erratum_835769_scan (bfd *input_bfd,
return TRUE;
}
+
+/* Resize all stub sections. */
+
+static void
+_bfd_aarch64_resize_stubs (struct elf_aarch64_link_hash_table *htab)
+{
+ asection *section;
+
+ /* OK, we've added some stubs. Find out the new size of the
+ stub sections. */
+ for (section = htab->stub_bfd->sections;
+ section != NULL; section = section->next)
+ {
+ /* Ignore non-stub sections. */
+ if (!strstr (section->name, STUB_SUFFIX))
+ continue;
+ section->size = 0;
+ }
+
+ bfd_hash_traverse (&htab->stub_hash_table, aarch64_size_one_stub, htab);
+}
+
+
/* Determine and set the size of the stub section for a final link.
The basic idea here is to examine all the relocations looking for
@@ -3453,18 +3476,7 @@ elfNN_aarch64_size_stubs (bfd *output_bfd,
if (!stub_changed)
break;
- /* OK, we've added some stubs. Find out the new size of the
- stub sections. */
- for (stub_sec = htab->stub_bfd->sections;
- stub_sec != NULL; stub_sec = stub_sec->next)
- {
- /* Ignore non-stub sections. */
- if (!strstr (stub_sec->name, STUB_SUFFIX))
- continue;
- stub_sec->size = 0;
- }
-
- bfd_hash_traverse (&htab->stub_hash_table, aarch64_size_one_stub, htab);
+ _bfd_aarch64_resize_stubs (htab);
/* Add erratum 835769 veneers to stub section sizes too. */
if (htab->fix_erratum_835769)
--
1.9.1