This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH][ARM][gas] Warn on deprecated ldm r<n>, {..., sp,...} and ldm r<n>, {...,lr,pc,...} forms
- From: "Jan Beulich" <JBeulich at suse dot com>
- To: "Kyrill Tkachov" <kyrylo dot tkachov at arm dot com>, "Richard Earnshaw" <rearnsha at arm dot com>
- Cc: "binutils at sourceware dot org" <binutils at sourceware dot org>
- Date: Wed, 14 Jan 2015 11:20:43 +0000
- Subject: Re: [PATCH][ARM][gas] Warn on deprecated ldm r<n>, {..., sp,...} and ldm r<n>, {...,lr,pc,...} forms
- Authentication-results: sourceware.org; auth=none
- References: <54B643E9 dot 10607 at arm dot com> <54B64F1D dot 2090102 at arm dot com>
>>> On 14.01.15 at 12:12, <rearnsha@arm.com> wrote:
> On 14/01/15 10:24, Kyrill Tkachov wrote:
>> Hi all,
>>
>> ARMv7-A deprecates ldm instructions that use the SP register in their list
>> as well as ldm instructions that use both LR and PC. GAS should warn
>> about them.
>>
>> This patch adds a warning for these forms.
>> Tests are added/updated.
>>
>> Tested check-gas in arm-none-eabi and I've had it sitting in my tree
>> being tested
>> with gcc for a few months now.
>>
>> What do people think?
>>
>
> I think firstly, that we should use as_tsktsk for deprecations, rather
> than warnings.
>
> I'm still somewhat concerned about the use of SP in LDM lists. This is
> going to make any legacy ABI code generated by GCC (-mapcs-frame) very
> verbose. I don't expect we will want to fix GCC to avoid this sequence.
>
> I'd like opinions from others on this one...
Perhaps such warnings risking to become very verbose should be
made optional, depending on a command line option and/or
directive?
Jan
- References:
- [PATCH][ARM][gas] Warn on deprecated ldm r<n>, {..., sp,...} and ldm r<n>, {...,lr,pc,...} forms
- Re: [PATCH][ARM][gas] Warn on deprecated ldm r<n>, {..., sp,...} and ldm r<n>, {...,lr,pc,...} forms