This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Add string representation of ELF e_flags for AVR.


On Tue, Dec 02, 2014 at 09:05:04AM +0000, Andrew Burgess wrote:
> Ping.
> 
> * Andrew Burgess <andrew.burgess@embecosm.com> [2014-11-24 11:29:10 +0000]:
> 
> > Adds a string representation of the ELF e_flags field for AVR in
> > readelf output, like lots of other targets.
> > 
> > OK to apply?
> > 
> > Thanks,
> > Andrew
> > 
> > ---
> > binutils/ChangeLog:
> > 
> > 	* readelf.c (decode_AVR_machine_flags): New function.
> > 	(get_machine_flags): Add EM_AVR case.

OK.  I'll note that strncat in this case seems overkill.  You have a
1024 char buffer of which you're using a max of 28 or so.

-- 
Alan Modra
Australia Development Lab, IBM


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]