This is the mail archive of the mailing list for the binutils project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[Patch] Fix build problem found by build robot

As reported by the build robot in

some binutils builds are failing, I see it when compiling binutils in 32 bit
mode on an x86 box targeting MIPS.  Compiling the toolchain in 64 bit mode
does not trigger the failure.

The failure is:

cc1: warnings being treated as errors
/scratch/gcc/nightly/src/binutils-gdb/bfd/ecoff.c: In function '_bfd_ecoff_slurp_symbol_table':
/scratch/gcc/nightly/src/binutils-gdb/bfd/ecoff.c:955: warning: comparison between signed and unsigned

Here is my proposed fix for the problem.  I cast bfd_get_symcount (which is 
unsigned int, the type of symcount in the bfd structure) to ptrdiff_t before
comparing it to 'internal_ptr - internal'.  Both of those variables are

OK for checkin?

Steve Ellcey

2014-12-02  Steve Ellcey  <>

	* ecoff.c (_bfd_ecoff_slurp_symbol_table): Add cast.

diff --git a/bfd/ecoff.c b/bfd/ecoff.c
index 70783b1..e72e254 100644
--- a/bfd/ecoff.c
+++ b/bfd/ecoff.c
@@ -952,7 +952,7 @@ _bfd_ecoff_slurp_symbol_table (bfd *abfd)
      and ecoff_data (abfd)->debug_info.symbolic_header.ifdMax can mean that
      we have fewer symbols than we were expecting.  Allow for this by updating
      the symbol count and warning the user.  */
-  if (internal_ptr - internal < bfd_get_symcount (abfd))
+  if (internal_ptr - internal < (ptrdiff_t) bfd_get_symcount (abfd))
       bfd_get_symcount (abfd) = internal_ptr - internal;

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]