This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH] dwarf.c handle new DWARFv5 C11, C++11 and C++14 DW_LANG constants.
- From: Mark Wielaard <mjw at redhat dot com>
- To: Sebastian Huber <sebastian dot huber at embedded-brains dot de>
- Cc: binutils at sourceware dot org
- Date: Mon, 01 Dec 2014 17:16:17 +0100
- Subject: Re: [PATCH] dwarf.c handle new DWARFv5 C11, C++11 and C++14 DW_LANG constants.
- Authentication-results: sourceware.org; auth=none
- References: <1416860956-29285-1-git-send-email-mjw at redhat dot com> <1417019098 dot 4954 dot 29 dot camel at bordewijk dot wildebeest dot org> <54773EBE dot 1010106 at embedded-brains dot de> <1417101289 dot 4954 dot 46 dot camel at bordewijk dot wildebeest dot org> <5478568A dot 8070903 at embedded-brains dot de> <1417173558 dot 4954 dot 50 dot camel at bordewijk dot wildebeest dot org> <5478648F dot 7020604 at embedded-brains dot de>
On Fri, 2014-11-28 at 13:03 +0100, Sebastian Huber wrote:
> On 28/11/14 12:19, Mark Wielaard wrote:
> > On Fri, 2014-11-28 at 12:03 +0100, Sebastian Huber wrote:
> >> On 27/11/14 16:14, Mark Wielaard wrote:
> >>> On Thu, 2014-11-27 at 16:09 +0100, Sebastian Huber wrote:
> >>>>> Out of curiosity why is this "ANSI C11" and not simply "C11" (like
> >>>>> "C++11") or "ISO C11"?
> >>> No particular reason, except to be consistent with the existing naming
> >>> used. DW_LANG_C89 was already "ANSI C" and DW_LANG_C_plus_plus was
> >>> already "C++".
> >> As far as I know there is no ANSI C11, the standard is ISO/IEC 9899:2011.
> > What is you recommendation then? Currently we have DW_LANG_C89/"ANSI C",
> > DW_LANG_C/"non-ANSI C", DW_LANG_C99/"ANSI C99" and DW_LANG_C11/"ANSI
> > C11".
>
> I would simply use "C11".
OK. Patch attached.
Cheers,
Mark
From e856b431b6984a8b1dbfbc50412a01b53409bb1f Mon Sep 17 00:00:00 2001
From: Mark Wielaard <mjw@redhat.com>
Date: Mon, 1 Dec 2014 17:13:59 +0100
Subject: [PATCH] dwarf.c: Change display name of DW_LANG_C11 to (C11).
Suggested-by: Sebastian Huber <sebastian.huber@embedded-brains.de>
---
binutils/ChangeLog | 5 +++++
binutils/dwarf.c | 2 +-
2 files changed, 6 insertions(+), 1 deletion(-)
diff --git a/binutils/ChangeLog b/binutils/ChangeLog
index ecb7c8b..282a1ad 100644
--- a/binutils/ChangeLog
+++ b/binutils/ChangeLog
@@ -1,3 +1,8 @@
+2014-12-01 Mark Wielaard <mjw@redhat.com>
+
+ * dwarf.c (read_and_display_attr_value): Change display name of
+ DW_LANG_C11 from (ANSI C11) to (C11).
+
2014-12-01 Nick Clifton <nickc@redhat.com>
PR binutils/17531
diff --git a/binutils/dwarf.c b/binutils/dwarf.c
index 5f953d5..f1e09b1 100644
--- a/binutils/dwarf.c
+++ b/binutils/dwarf.c
@@ -1936,7 +1936,7 @@ read_and_display_attr_value (unsigned long attribute,
/* DWARF 5 values. */
case DW_LANG_Go: printf ("(Go)"); break;
case DW_LANG_C_plus_plus_11: printf ("(C++11)"); break;
- case DW_LANG_C11: printf ("(ANSI C11)"); break;
+ case DW_LANG_C11: printf ("(C11)"); break;
case DW_LANG_C_plus_plus_14: printf ("(C++14)"); break;
/* MIPS extension. */
case DW_LANG_Mips_Assembler: printf ("(MIPS assembler)"); break;
--
1.8.3.1