This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: --enable-targets=all compilation error
- From: "H.J. Lu" <hjl dot tools at gmail dot com>
- To: Jan Kratochvil <jan dot kratochvil at redhat dot com>
- Cc: Binutils <binutils at sourceware dot org>, Nick Clifton <nickc at redhat dot com>
- Date: Thu, 13 Nov 2014 12:17:09 -0800
- Subject: Re: --enable-targets=all compilation error
- Authentication-results: sourceware.org; auth=none
- References: <20141113194126 dot GA22730 at host2 dot jankratochvil dot net>
On Thu, Nov 13, 2014 at 11:41 AM, Jan Kratochvil
<jan.kratochvil@redhat.com> wrote:
> Hi Nick,
>
> commit a5c71af8d3c7c535f27614947f72883233658706
> Author: Nick Clifton <nickc@redhat.com>
> Date: Thu Nov 13 17:46:11 2014 +0000
> More fixes for memory access violations whilst scanning corrupt binaries.
> PR binutils/17512
>
> coffcode.h: In function âcoff_pointerize_aux_hookâ:
> coffcode.h:2543:7: error: âsymbbolâ undeclared (first use in this function)
> coffcode.h:2543:7: note: each undeclared identifier is reported only once for each function it appears in
> coffcode.h:2547:1: error: control reaches end of non-void function [-Werror=return-type]
> cc1: all warnings being treated as errors
>
I checked in this as an obvious fix.
--
H.J.
---
diff --git a/bfd/ChangeLog b/bfd/ChangeLog
index 3cf91d1..f1f0077 100644
--- a/bfd/ChangeLog
+++ b/bfd/ChangeLog
@@ -1,5 +1,9 @@
2014-11-13 H.J. Lu <hongjiu.lu@intel.com>
+ * coffcode.h (coff_pointerize_aux_hook): Fix a typo.
+
+2014-11-13 H.J. Lu <hongjiu.lu@intel.com>
+
PR gas/17598
* elf64-x86-64.c (elf_x86_64_check_relocs): Treat
R_X86_64_GOTPLT64 the same as R_X86_64_GOT64.
diff --git a/bfd/coffcode.h b/bfd/coffcode.h
index c32b20d..69992db 100644
--- a/bfd/coffcode.h
+++ b/bfd/coffcode.h
@@ -2540,7 +2540,7 @@ coff_pointerize_aux_hook (bfd *abfd ATTRIBUTE_UNUSED,
/* Return TRUE if we don't want to pointerize this aux entry, which
is the case for the lastfirst aux entry for a C_LEAFPROC symbol. */
return (indaux == 1
- && symbbol->is_sym
+ && symbol->is_sym
&& (symbol->u.syment.n_sclass == C_LEAFPROC
|| symbol->u.syment.n_sclass == C_LEAFSTAT
|| symbol->u.syment.n_sclass == C_LEAFEXT));