This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [gold][aarch64]Patch for Relaxation
- From: Cary Coutant <ccoutant at google dot com>
- To: Ian Lance Taylor <iant at google dot com>
- Cc: Ryan Mansfield <rmansfield at qnx dot com>, Binutils <binutils at sourceware dot org>
- Date: Fri, 17 Oct 2014 16:32:52 -0700
- Subject: Re: [gold][aarch64]Patch for Relaxation
- Authentication-results: sourceware.org; auth=none
- References: <CACkGtrhqMpo-Fdt+39XJTLTjjJtz3essmdDEdQY8Owni66sgkw at mail dot gmail dot com> <CAHACq4q2f3bhz4tWHMbz1zLbGDskopaomqveTn_A0ZjwXcBH4Q at mail dot gmail dot com> <CACkGtrjxw9d9GRmiz=ztCne6n8+Dv17jegM45db7HkMLUmy2Qw at mail dot gmail dot com> <CAHACq4rWadE1fDRMZOmqZ4Mr1Qago25a_cd9+u04y9M0b691ug at mail dot gmail dot com> <CACkGtrgoWM8f1Oc71nVTGDrNztCt0BCx1-FiQavn=QOLpZ4tnA at mail dot gmail dot com> <CAHACq4q6_XqUx9ObfG-TZLzAzh_-6L+K45osA_KJ2rTLdvQs6g at mail dot gmail dot com> <543FE312 dot 7090205 at qnx dot com> <CAKOQZ8zTmMNsDnFobgch+-NTu5f8ZoA1u-QYiPVTSsH8aGM8aA at mail dot gmail dot com> <CAHACq4r_DfDOvQuW3jpkm2dObGRd7q5hLcjPEksR8XbgoMDSNw at mail dot gmail dot com> <CAHACq4rh0WMhKZ345+ZBGhhUHrXNVOFG4a11BdP8ZieDChnnxw at mail dot gmail dot com> <CAHACq4o9rYQ+DGWmMPc-6F8Zyzw5VZMhpGYRNu8fbrdiqhpzJw at mail dot gmail dot com>
I've committed the following patch.
I have not verified that this is sufficient to get it to compile with
GCC 4.2. I did look for other cases where "typename" might be needed,
but didn't find any. Please let me know if you run into any other
problems.
-cary
2014-10-17 Cary Coutant <ccoutant@google.com>
gold/
* aarch64.cc (AArch64_relocate_functions::maybe_apply_stub):
Add "typename" keyword.
diff --git a/gold/aarch64.cc b/gold/aarch64.cc
index 7ce295a..e2bdf95 100644
--- a/gold/aarch64.cc
+++ b/gold/aarch64.cc
@@ -4093,7 +4093,7 @@ maybe_apply_stub(unsigned int r_type,
const AArch64_reloc_property* arp =
aarch64_reloc_property_table->get_reloc_property(r_type);
gold_assert(arp != NULL);
- This::Status status = This::template
+ typename This::Status status = This::template
rela_general<32>(view, branch_offset, 0, arp);
if (status != This::STATUS_OKAY)
gold_error(_("Stub is too far away, try a smaller value "