This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
RE: [PATCH] MIPS/GAS: Correct file option settings with `.insn'
- From: Matthew Fortune <Matthew dot Fortune at imgtec dot com>
- To: "Maciej W. Rozycki" <macro at codesourcery dot com>, "binutils at sourceware dot org" <binutils at sourceware dot org>
- Date: Sun, 12 Oct 2014 08:37:36 +0000
- Subject: RE: [PATCH] MIPS/GAS: Correct file option settings with `.insn'
- Authentication-results: sourceware.org; auth=none
- References: <alpine dot DEB dot 1 dot 10 dot 1410112254470 dot 19130 at tp dot orcam dot me dot uk>
> binutils-gas-mips-insn-check-options.diff
> Index: binutils-fsf-trunk-quilt/gas/config/tc-mips.c
> ===================================================================
> --- binutils-fsf-trunk-quilt.orig/gas/config/tc-mips.c 2014-08-21
> 13:05:39.000000000 +0100
> +++ binutils-fsf-trunk-quilt/gas/config/tc-mips.c 2014-10-11
> 23:15:09.817805607 +0100
> @@ -16003,6 +16003,10 @@ s_cpadd (int ignore ATTRIBUTE_UNUSED)
> static void
> s_insn (int ignore ATTRIBUTE_UNUSED)
> {
> + file_mips_check_options ();
> + file_ase_mips16 |= mips_opts.mips16;
> + file_ase_micromips |= mips_opts.micromips;
> +
> mips_mark_labels ();
I can't approve it but this looks correct. Thanks for finding/fixing.
Matthew