This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [patch] Fix handling of common symbols with plugins
- From: "H.J. Lu" <hjl dot tools at gmail dot com>
- To: Cary Coutant <ccoutant at google dot com>
- Cc: Rafael EspÃndola <rafael dot espindola at gmail dot com>, Binutils <binutils at sourceware dot org>
- Date: Wed, 17 Sep 2014 10:20:38 -0700
- Subject: Re: [patch] Fix handling of common symbols with plugins
- Authentication-results: sourceware.org; auth=none
- References: <CAG3jRe+9-c3erPGakOydZfpEZAD5Fw=bEP1EV7MyFFp33wApQQ at mail dot gmail dot com> <CAHACq4oaSAUUpn08eFfN488kSa8J9pkKxTEQgzKR5Z8KbbWMkQ at mail dot gmail dot com>
On Wed, Sep 17, 2014 at 10:17 AM, Cary Coutant <ccoutant@google.com> wrote:
>> gold
>> 2014-09-09 Rafael Ãvila de EspÃndola <respindola@mozilla.com>
>>
>> * plugin.cc (Sized_pluginobj::do_add_symbols): Ignore isym->size.
>> * resolve.cc (Symbol_table::resolve): Don't override common symbols
>> during the replacement phase.
>
> The gold patch looks good to me. Thanks!
>
>> include
>> 2014-09-09 Rafael Ãvila de EspÃndola <respindola@mozilla.com>
>>
>> * plugin-api.h (ld_plugin_symbol): Note that size is ignored.
>
> This is OK if the ld patch is also approved.
>
>> ld
>> 2014-09-09 Rafael Ãvila de EspÃndola <respindola@mozilla.com>
>>
>> * plugin.c (asymbol_from_plugin_symbol): Ignore ldsym->size.
>> * testplug.c (parse_symdefstr): Ignore sym->size.
>
> Maybe HJ should look at this?
>
Can you add an ld testcase to ld/testsuite/ld-plugin/lto.exp?
--
H.J.