This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] gas/config/tc-score7.c: Use symbol_get_frag() instead of direct reference to fix segment fault issue


Hi Chen,

Is it patch OK? please help check when you have free time, thanks.

Approved and applied. Note - there were similar errors in tc-score.c so I fixed them at the same time.

Originally, I could not find the related Changelog for 'gas', so I did
not mark change log for it.

All patches should have a changelog entry, so I created this for yours:

gas/ChangeLog
2014-06-13  Chen Gang  <gang.chen.5i5j@gmail.com>

* config/tc-score7.c: (s7_b32_relax_to_b16): Use symbol_get_frag() to access a symbol's
	frag.
	* config/tc-score.c (s3_relax_branch_inst16): Likewise.
	(s3_relax_cmpbranch_inst32): Likewise.



Also - this is a situation where it would have been appropriate to create an official bug report on the bugzilla system.

Cheers
  Nick


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]