This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [patch] Fix or1k gcc-4.9 -m32 compilation error
- From: "Maciej W. Rozycki" <macro at codesourcery dot com>
- To: Jan Kratochvil <jan dot kratochvil at redhat dot com>, Stefan Kristiansson <stefan dot kristiansson at saunalahti dot fi>
- Cc: <binutils at sourceware dot org>
- Date: Mon, 9 Jun 2014 20:43:23 +0100
- Subject: Re: [patch] Fix or1k gcc-4.9 -m32 compilation error
- Authentication-results: sourceware.org; auth=none
- References: <20140609190257 dot GA17807 at host2 dot jankratochvil dot net>
On Mon, 9 Jun 2014, Jan Kratochvil wrote:
> Fedora Rawhide i686 (32-bit)
> gcc-4.9.0-8.fc21.i686
> libtool: compile: gcc -DHAVE_CONFIG_H -I. -I. -I. -I../bfd -I./../include -I./../bfd -W -Wall -Wstrict-prototypes -Wmissing-prototypes -Wshadow -Werror -g3 -pipe -Wall -fexceptions -fstack-protector-strong --param=ssp-buffer-size=4 -ftrack-macro-expansion=0 -fno-diagnostics-show-caret -fsanitize=address -MT or1k-asm.lo -MD -MP -MF .deps/or1k-asm.Tpo -c or1k-asm.c -o or1k-asm.o
> In file included from or1k-asm.c:34:0:
> or1k-desc.h:260:73: error: this decimal constant is unsigned only in ISO C90 [-Werror]
> or1k-desc.h:263:73: error: this decimal constant is unsigned only in ISO C90 [-Werror]
> or1k-desc.h:270:4: error: this decimal constant is unsigned only in ISO C90 [-Werror]
> cc1: all warnings being treated as errors
> make[4]: *** [or1k-asm.lo] Error 1
>
> OK to check it in?
>
>
> Thanks,
> Jan
>
>
> opcodes/
> 2014-06-09 Jan Kratochvil <jan.kratochvil@redhat.com>
>
> * or1k-desc.h (SPR_FIELD_MASK_SYS_VR_VER, SPR_FIELD_MASK_SYS_UPR_CUP)
> (SPR_FIELD_MASK_SYS_SR_CID): Add U suffix.
First, this is a generated file, your change will go away the next time
the maintainer regenerates it. Second, it's been discussed to death
recently and a conclusion made this needs to be fixed in CGEN even rather
than the template this file has been made from before it is regenerated.
I don't know what happened to the fix -- Stefan, any progress on that?
Maciej