This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
RE: as error output not -j64 safe
- From: Matthew Fortune <Matthew dot Fortune at imgtec dot com>
- To: Mike Stump <mikestump at comcast dot net>, Alan Modra <amodra at gmail dot com>
- Cc: Andrew Pinski <pinskia at gmail dot com>, binutils <binutils at sourceware dot org>, Richard Sandiford <rdsandiford at googlemail dot com>
- Date: Tue, 20 May 2014 22:48:57 +0000
- Subject: RE: as error output not -j64 safe
- Authentication-results: sourceware.org; auth=none
- References: <819223B1-7BDF-46C0-80CE-EF49878BA3C8 at comcast dot net> <CA+=Sn1m3VExcetsFHU62+aKDbQYyZTJjYjX1UE0KfovhwyhyXw at mail dot gmail dot com> <36FD025D-0FE1-4248-A154-E28F998F5B73 at comcast dot net> <20140516085119 dot GW5162 at bubble dot grove dot modra dot org> <F49F0B3C-666F-435A-AD35-7906944F6D0D at comcast dot net> <6D39441BF12EF246A7ABCE6654B02353539192 at LEMAIL01 dot le dot imgtec dot org>
> This patch has broken a lot of expected output in the gas testsuite.
> Are individual ports expected to deal with the fallout or has this been
> done already but awaiting commit? MIPS has 133 failures with this patch
> applied.
I didn't check the exact cause earlier. It is just extra whitespace
introduced in the refactoring. Committed as obvious, (hoping that is the
right way to treat this sort of fix).
Regards,
Matthew
* messages.c (as_warn_internal): Remove extra whitespace from
warning messages.
---
gas/ChangeLog | 5 +++++
gas/messages.c | 6 +++---
2 files changed, 8 insertions(+), 3 deletions(-)
diff --git a/gas/ChangeLog b/gas/ChangeLog
index 130b287..51974b5 100644
--- a/gas/ChangeLog
+++ b/gas/ChangeLog
@@ -1,5 +1,10 @@
2014-05-20 Matthew Fortune <matthew.fortune@imgtec.com>
+ * messages.c (as_warn_internal): Remove extra whitespace from
+ warning messages.
+
+2014-05-20 Matthew Fortune <matthew.fortune@imgtec.com>
+
* config/tc-mips.c (FP64_ASES): Add ASE_MSA.
(mips_after_parse_args): Do not select ASE_MSA without -mfp64.
diff --git a/gas/messages.c b/gas/messages.c
index 05c7442..d592b36 100644
--- a/gas/messages.c
+++ b/gas/messages.c
@@ -151,12 +151,12 @@ as_warn_internal (char *file, unsigned int line, char *buffer)
if (file)
{
if (line != 0)
- fprintf (stderr, "%s:%u: %s %s\n", file, line, _("Warning: "), buffer);
+ fprintf (stderr, "%s:%u: %s %s\n", file, line, _("Warning:"), buffer);
else
- fprintf (stderr, "%s: %s %s\n", file, _("Warning: "), buffer);
+ fprintf (stderr, "%s: %s %s\n", file, _("Warning:"), buffer);
}
else
- fprintf (stderr, "%s %s\n", _("Warning: "), buffer);
+ fprintf (stderr, "%s %s\n", _("Warning:"), buffer);
#ifndef NO_LISTING
listing_warning (buffer);
#endif
--
1.7.1
> > -----Original Message-----
> > From: binutils-owner@sourceware.org [mailto:binutils-
> owner@sourceware.org]
> > On Behalf Of Mike Stump
> > Sent: 20 May 2014 21:28
> > To: Alan Modra
> > Cc: Andrew Pinski; binutils
> > Subject: Re: as error output not -j64 safe
> >
> > On May 16, 2014, at 1:51 AM, Alan Modra <amodra@gmail.com> wrote:
> > > OK.
> >
> > Thanks. I noticed you tricksy people switched to git, welcome to 2005.
> >
> > > Please also fix as_warn_internal similarly to the above.
> >
> > Done.
> >
> > > There are quite a few more cases of the same problem in this file, if
> you
> > > care to look..
> >
> > Gosh, I want to solve these with fmemopen, but, that is not as portable
> as
> > the existing code... In any event, I'm not set up to do as much testing
> as
> > I'd like for move invasive changes...
> >
> > Here is what I checked in:
> >
> > 2014-05-20 Mike Stump <mikestump@comcast.net>
> >
> > * messages.c (as_warn_internal): Ensure we don't interleave output
> > within a single line when make -j is used.
> > (as_bad_internal): Likewise.