This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH, i386] Add support for xsavec, xsaves, clflushopt ISA extensions.
- From: "H.J. Lu" <hjl dot tools at gmail dot com>
- To: Ilya Tocar <tocarip dot intel at gmail dot com>
- Cc: Binutils <binutils at sourceware dot org>
- Date: Thu, 20 Mar 2014 10:26:07 -0700
- Subject: Re: [PATCH, i386] Add support for xsavec, xsaves, clflushopt ISA extensions.
- Authentication-results: sourceware.org; auth=none
- References: <20140211145021 dot GA101176 at msticlxl7 dot ims dot intel dot com> <CAMe9rOoZRSLg5jSr_KAj+8RUaXs_PbNp1bRawvhCggcFp6K_BQ at mail dot gmail dot com> <CAFFGCRAMnv4dr5L9L_=odKzDfR5Sr0xMDz6uPYtvhH42cbZX2w at mail dot gmail dot com> <20140212110710 dot GA32294 at msticlxl7 dot ims dot intel dot com> <CAMe9rOpBTuWXjACPjbZ1r2b-Z_6wMyidBtCHmaWCkVmwoX9RLw at mail dot gmail dot com>
On Wed, Feb 12, 2014 at 7:53 AM, H.J. Lu <hjl.tools@gmail.com> wrote:
> On Wed, Feb 12, 2014 at 3:07 AM, Ilya Tocar <tocarip.intel@gmail.com> wrote:
>> On 12 Feb 14:36, Ilya Tocar wrote:
>>> 2014-02-11 19:41 GMT+04:00 H.J. Lu <hjl.tools@gmail.com>:
>>> >
>>> > On Tue, Feb 11, 2014 at 6:50 AM, Ilya Tocar <tocarip.intel@gmail.com> wrote:
>>> > > Hi,
>>> > > This patch add support for xsavec, xsaves ISA extensions, introduced in
>>> > > [1], and clflushopt introduced in [2].
>>> > >
>>> > > [1]http://www.intel.com/content/www/us/en/processors/architectures-software-developer-manuals.html
>>> > > [2]http://software.intel.com/en-us/file/319433-018pdf
>>> > >
>>> > > Testing passes. Ok for trunk?
>>> > >
>>> >
>>> > Please update ChangeLog and use "git format-patch" to create
>>> > the patch so that one can use "git am" + "git rebase" to apply
>>> > patch.
>>> >
>>> > Thanks.
>>> >
>>> > --
>>> > H.J.
>>>
>>> Sorry for resending, i forgot about plain-text only.
>>>
>>> Updated ChangeLogs, result of git format-patch (gzipped) attached.
>>> Ok for trunk?
>>
>> Maillist detected spam, so resending again.
>
> It looks good. I checked it in for you. 2 things to check
> next time. I used "git am --whitespace=fix":
>
> Applying: Add clflushopt, xsaves, xsavec, xrstors.
> /export/gnu/import/git/sources/binutils-gdb/.git/rebase-apply/patch:57:
> trailing whitespace.
> 2014-02-12 Ilya Tocar <ilya.tocar@intel.com>
> /export/gnu/import/git/sources/binutils-gdb/.git/rebase-apply/patch:557:
> trailing whitespace.
> 2014-02-12 Ilya Tocar <ilya.tocar@intel.com>
> /export/gnu/import/git/sources/binutils-gdb/.git/rebase-apply/patch:570:
> trailing whitespace.
> xsaves64, xsavec, xsavec64.
> /export/gnu/import/git/sources/binutils-gdb/.git/rebase-apply/patch:35164:
> trailing whitespace.
> { { 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
> /export/gnu/import/git/sources/binutils-gdb/.git/rebase-apply/patch:35165:
> trailing whitespace.
> 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
> warning: squelched 55 whitespace errors
> warning: 59 lines applied after fixing whitespace errors.
>
> I also added ChangeLog entries to your commit log.
>
I backported it to binutils-2_24-branch.
--
H.J