This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: Commit: Fix binutils strip test
- From: "H.J. Lu" <hjl dot tools at gmail dot com>
- To: Nick Clifton <nickc at redhat dot com>
- Cc: Binutils <binutils at sourceware dot org>
- Date: Tue, 28 Jan 2014 05:41:58 -0800
- Subject: Re: Commit: Fix binutils strip test
- Authentication-results: sourceware.org; auth=none
- References: <87zjmgp6xs dot fsf at redhat dot com>
On Tue, Jan 28, 2014 at 5:33 AM, Nick Clifton <nickc@redhat.com> wrote:
> Hi Guys,
>
> A recent change to the BFD library has meant that the osabi field in
> ELF headers will be copied from input files. This in turn has broken
> the strip-10 test in the binutils testsuite, so I am applying the
> patch below to fix the problem.
>
> Cheers
> Nick
>
> binutils/testsuite/ChangeLog
> 2014-01-28 Nick Clifton <nickc@redhat.com>
>
> PR binutils/16318
> * binutils-all/strip-10.d: Allow "System V" in the osabi field.
>
> diff --git a/binutils/testsuite/binutils-all/strip-10.d b/binutils/testsuite/binutils
> index f4cf76d..949bc67 100644
> --- a/binutils/testsuite/binutils-all/strip-10.d
> +++ b/binutils/testsuite/binutils-all/strip-10.d
> @@ -5,6 +5,6 @@
> #name: strip on STB_GNU_UNIQUE
>
> #...
> - OS/ABI:[ \t]+UNIX - GNU
> + OS/ABI:[ \t]+UNIX - (GNU|System V)
> #...
Using STB_GNU_UNIQUE should set OSABI to GNU.
It is a bug if it doesn't happen. This patch just hides
the real bug.
--
H.J.