This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [Patch bfd] Remove unneeded comma expression from bfd_set_section_userdata, bfd_set_section_alignment, bfd_set_section_vma
- From: Tom Tromey <tromey at redhat dot com>
- To: Ramana Radhakrishnan <ramrad01 at arm dot com>
- Cc: "binutils\ at sourceware dot org" <binutils at sourceware dot org>
- Date: Mon, 27 Jan 2014 10:32:57 -0700
- Subject: Re: [Patch bfd] Remove unneeded comma expression from bfd_set_section_userdata, bfd_set_section_alignment, bfd_set_section_vma
- Authentication-results: sourceware.org; auth=none
- References: <52E6435E dot 7030706 at arm dot com> <52E681AE dot 30806 at arm dot com>
>>>>> "Ramana" == Ramana Radhakrishnan <ramrad01@arm.com> writes:
Ramana> Uggh, it looks like I didn't test when the hunks included
Ramana> bfd_set_section_vma and bfd_set_section_alignment because this expects
Ramana> the TRUE to be meaningful and uses that in conditions in a number of
Ramana> places.
Ramana> The problem though is real and builds appear to be broken with
Ramana> trunk gcc.
I wonder if it would be acceptable to replace it with a static inline
function. I think that would avoid the warning. "static inline" is
already unconditionally used in BFD, so I don't think there's a
portability issue.
Tom