This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [RFC PATCH] bfd/elf32-arm.c: Set st_value to zero for undefined symbols.
- From: Will Newton <will dot newton at linaro dot org>
- To: "binutils at sourceware dot org" <binutils at sourceware dot org>
- Date: Thu, 23 Jan 2014 15:22:21 +0000
- Subject: Re: [RFC PATCH] bfd/elf32-arm.c: Set st_value to zero for undefined symbols.
- Authentication-results: sourceware.org; auth=none
- References: <1389868125-7349-1-git-send-email-will dot newton at linaro dot org>
On 16 January 2014 10:28, Will Newton <will.newton@linaro.org> wrote:
> I'm not sure what the implications of this patch are, so I thought I would
> post it here in the hope that someone can explain what might break.
>
> The issue comes from a report that Qt does not work correctly on ARM when
> built with -Bsymbolic:
>
> http://lists.linaro.org/pipermail/linaro-toolchain/2014-January/003942.html
>
> Unless point_equality_needed is set then set st_value to be zero
> for undefined symbols.
>
> bfd/ChangeLog:
>
> 2014-01-10 Will Newton <will.newton@linaro.org>
>
> * elf32-arm.c (elf32_arm_check_relocs): Set
> pointer_equality_needed for absolute references within
> executable links.
> (elf32_arm_finish_dynamic_symbol): Set st_value to zero
> unless pointer_equality_needed is set.
>
> ld/testsuite/ChangeLog:
>
> 2014-01-10 Will Newton <will.newton@linaro.org>
>
> * ld-arm/ifunc-14.rd: Update symbol values.
> ---
> bfd/elf32-arm.c | 7 ++++++-
> ld/testsuite/ld-arm/ifunc-14.rd | 4 ++--
> 2 files changed, 8 insertions(+), 3 deletions(-)
Ping?
--
Will Newton
Toolchain Working Group, Linaro