This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH] PR gas/16489: GAS doesn't complain about same register used for destination and index in AVX512 gather insn
- From: "H.J. Lu" <hjl dot tools at gmail dot com>
- To: "Michael V. Zolotukhin" <michael dot v dot zolotukhin at gmail dot com>
- Cc: Jan Beulich <JBeulich at suse dot com>, Binutils <binutils at sourceware dot org>
- Date: Wed, 22 Jan 2014 10:02:37 -0800
- Subject: Re: [PATCH] PR gas/16489: GAS doesn't complain about same register used for destination and index in AVX512 gather insn
- Authentication-results: sourceware.org; auth=none
- References: <20140122140229 dot GA44568 at msticlxl57 dot ims dot intel dot com> <CAMe9rOqdG9MbZmgWscDNUwtxe4Qwmcgt3ppRR3u5bt9YAJaCmA at mail dot gmail dot com> <CANtU07-9W7yu1KrEL+TgnkYnxwv8GwMQR6M_q0TKuORFw-GCEA at mail dot gmail dot com> <CAMe9rOp3Z=pfy=RFL4ic5vJ4img=ZZAGDzfqf20z9S1GSw57Pg at mail dot gmail dot com> <CANtU07-0Jap2x_6mZRhc6t9T5zb5x8dBeha3=oPWPMEi66Pyug at mail dot gmail dot com> <CAMe9rOpDkKfXGnNh5rPQ0dJ2XE-Rd1h1bwKK12iZo2FiM3pOkA at mail dot gmail dot com> <CANtU078gCG94MpjiK5u=19+D8=jqK_=-2YFuWhWydRH=ZsbqJg at mail dot gmail dot com> <CAMe9rOrFtE2Wu1L3p33CkO_7VYePVXX6_wSg_rHgUQzi0GF33Q at mail dot gmail dot com> <20140122175148 dot GB44568 at msticlxl57 dot ims dot intel dot com>
On Wed, Jan 22, 2014 at 9:51 AM, Michael V. Zolotukhin
<michael.v.zolotukhin@gmail.com> wrote:
>> Please submit a separate patch for assert change. I
>> will take a closer look later.
> Ok, here is the fix for the PR16489 without change in this assert. Ok for
> trunk?
>
> gas/Changelog:
> 2014-01-21 Michael Zolotukhin <michael.v.zolotukhin@gmail.com>
>
> * config/tc-i386.c (check_VecOperands): Add check for invalid
> register set in AVX512 gathers.
>
> gas/testsuite/Changelog:
> 2014-01-21 Michael Zolotukhin <michael.v.zolotukhin@gmail.com>
> * gas/i386/vgather-check.s: Add tests for AVX512 gathers.
> * gas/i386/x86-64-vgather-check.s: Likewise.
> * gas/i386/vgather-check-error.l: Update correspondingly.
> * gas/i386/vgather-check-none.d: Likewise.
> * gas/i386/vgather-check-warn.d: Likewise.
> * gas/i386/vgather-check-warn.e: Likewise.
> * gas/i386/vgather-check.d: Likewise.
> * gas/i386/x86-64-vgather-check-error.l: Likewise.
> * gas/i386/x86-64-vgather-check-none.d: Likewise.
> * gas/i386/x86-64-vgather-check-warn.d: Likewise.
> * gas/i386/x86-64-vgather-check-warn.e: Likewise.
> * gas/i386/x86-64-vgather-check.d: Likewise.
>
I checked it in for you. I changed ChangeLog to
2014-01-22 Michael Zolotukhin <michael.v.zolotukhin@gmail.com>
PR gas/16489
Please remember use the correct date and PR # next time.
Thanks.
--
H.J.