This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Bug: gather/scatter accepts same registers in destination/src and index


On Tue, Jan 21, 2014 at 3:16 AM, Michael V. Zolotukhin
<michael.v.zolotukhin@gmail.com> wrote:
> Hi,
>
> The patch is below, is it ok for trunk?  I chose name 'vgather-scatter-check'
> for the tests, as I think 'vsg' is a bit ambiguous.
>
> gas/Changelog:
> 2014-01-21  Michael Zolotukhin  <michael.v.zolotukhin@gmail.com>
>
>         * config/tc-i386.c (check_VecOperands): Add check for invalid
>         register set in AVX512 gathers/scatters.
>
> gas/testsuite/Changelog:
> 2014-01-21  Michael Zolotukhin  <michael.v.zolotukhin@gmail.com>
>         * gas/i386/i386.exp: Rename vgather-check to vgather-scatter-check.
>         * gas/i386/vgather-check-error.l: Add tests and rename to ...
>         * gas/i386/vgather-scatter-check-error.l: This.
>         * gas/i386/vgather-check-error.s: Add tests and rename to ...
>         * gas/i386/vgather-scatter-check-error.s: This.
>         * gas/i386/vgather-check-none.d: Add tests and rename to ...
>         * gas/i386/vgather-scatter-check-none.d: This.
>         * gas/i386/vgather-check-none.s: Add tests and rename to ...
>         * gas/i386/vgather-scatter-check-none.s: This.
>         * gas/i386/vgather-check-warn.d: Add tests and rename to ...
>         * gas/i386/vgather-scatter-check-warn.d: This.
>         * gas/i386/vgather-check-warn.e: Add tests and rename to ...
>         * gas/i386/vgather-scatter-check-warn.e: This.
>         * gas/i386/vgather-check.d: Add tests and rename to ...
>         * gas/i386/vgather-scatter-check.d: This.
>         * gas/i386/vgather-check.s: Add tests and rename to ...
>         * gas/i386/vgather-scatter-check.s: This.
>         * gas/i386/x86-64-vgather-check-error.l: Add tests and rename to ...
>         * gas/i386/x86-64-vgather-scatter-check-error.l: This.
>         * gas/i386/x86-64-vgather-check-error.s: Add tests and rename to ...
>         * gas/i386/x86-64-vgather-scatter-check-error.s: This.
>         * gas/i386/x86-64-vgather-check-none.d: Add tests and rename to ...
>         * gas/i386/x86-64-vgather-scatter-check-none.d: This.
>         * gas/i386/x86-64-vgather-check-none.s: Add tests and rename to ...
>         * gas/i386/x86-64-vgather-scatter-check-none.s: This.
>         * gas/i386/x86-64-vgather-check-warn.d: Add tests and rename to ...
>         * gas/i386/x86-64-vgather-scatter-check-warn.d: This.
>         * gas/i386/x86-64-vgather-check-warn.e: Add tests and rename to ...
>         * gas/i386/x86-64-vgather-scatter-check-warn.e: This.
>         * gas/i386/x86-64-vgather-check.d: Add tests and rename to ...
>         * gas/i386/x86-64-vgather-scatter-check.d: This.
>         * gas/i386/x86-64-vgather-check.s: Add tests and rename to ...
>         * gas/i386/x86-64-vgather-scatter-check.s: This.
>

Please make 2 patches:

1. Rename testcases without fixing any bugs.
2. Fix the bug.

Thanks.

H.J.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]