This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH] PR ld/16467: Check incompatible existing default symbol definition
- From: Alan Modra <amodra at gmail dot com>
- To: "H.J. Lu" <hjl dot tools at gmail dot com>
- Cc: binutils at sourceware dot org
- Date: Mon, 20 Jan 2014 17:28:47 +1030
- Subject: Re: [PATCH] PR ld/16467: Check incompatible existing default symbol definition
- Authentication-results: sourceware.org; auth=none
- References: <20140120013428 dot GA1497 at gmail dot com>
On Sun, Jan 19, 2014 at 05:34:28PM -0800, H.J. Lu wrote:
> After resolving a versioned reference, foo@VER1, to a default versioned
> definition, foo@@VER1, from a shared object, we also merge it with
> the existing default symbol definition, foo. When foo is IFUNC and
> foo@@VER1 aren't, we will merge 2 incompatible definitions. This
> patch avoids merging foo@@VER1 definition with foo definition if
> one is IFUNC and the other isn't. OK for trunk and 2.24?
Isn't this another case like PR2404? Can't you modify the PR2404 code
you added to _bfd_elf_merge_symbol rather than changing
_bfd_elf_add_default_symbol?
--
Alan Modra
Australia Development Lab, IBM