This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH][x86] Fix for objdump internal error

From: Michael Zolotukhin <michael dot v dot zolotukhin at gmail dot com>
To: "H.J. Lu" <hjl dot tools at gmail dot com>
Cc: "binutils at sourceware dot org" <binutils at sourceware dot org>, Kirill Yukhin <kirill dot yukhin at gmail dot com>
Date: Tue, 17 Dec 2013 20:54:59 +0400
Subject: Re: [PATCH][x86] Fix for objdump internal error
Authentication-results: sourceware.org; auth=none
References: <CANtU07-Nd8WbmmTzE5ZQg9wD8qmoGm4OgPuQ_VgSjoK9jCGt0w at mail dot gmail dot com> <CAMe9rOqkDLx8hiocEJuwMG9cZnGdPFXwt5ij88=aKj24fT5APg at mail dot gmail dot com> <CANtU078xeGU8tfapoJtfUmJU3rkfRvqKkC6_7Y-zK10EiBWiTA at mail dot gmail dot com> <CAMe9rOpWFwRJcxMrR4t02ykBre0Qni-_ApHHz1ED2q7m31u8WA at mail dot gmail dot com>

Thanks,

Updated patch is attached.

gas/testsuite/Changelog:
2013-12-17  Michael Zolotukhin  <michael.v.zolotukhin@gmail.com>

        * gas/i386/disassem.s: New.
        * gas/i386/disassem.d: New.
        * gas/i386/x86-64-disassem.s: New.
        * gas/i386/x86-64-disassem.d: New.
        * gas/i386/i386.exp: Call new tests.


opcodes/Changelog:
2013-12-17  Michael Zolotukhin  <michael.v.zolotukhin@gmail.com>

        * i386-dis.c (MOD_FF_REG_3): New.
        (MOD_FF_REG_5): New.
        (mod_table): Add new entries.
        (reg_table): MOD_FF_REG_3 and MOD_FF_REG_5.


Thanks,
Michael

On 17 December 2013 20:47, H.J. Lu <hjl.tools@gmail.com> wrote:
> On Tue, Dec 17, 2013 at 8:30 AM, Michael Zolotukhin
> <michael.v.zolotukhin@gmail.com> wrote:
>> Hi HJ,
>>
>> Attached is patch with the tests. Ok for trunk?
>>
>> gas/testsuite/Changelog:
>> 2013-12-17  Michael Zolotukhin  <michael.v.zolotukhin@gmail.com>
>>
>>         * gas/i386/disassem.s: New.
>>         * gas/i386/disassem.d: New.
>>         * gas/i386/x86-64-disassem.s: New.
>>         * gas/i386/x86-64-disassem.d: New.
>>         * gas/i386/i386.exp: Call new tests.
>>
>>
>> opcodes/Changelog:
>> 2013-12-17  Michael Zolotukhin  <michael.v.zolotukhin@gmail.com>
>>
>>         * i386-dis.c (MOD_FF_REG_3): New.
>>         (MOD_FF_REG_5): New.
>>         (mod_table): Add new entries.
>>         (reg_table): Fix decoding of ljmp and lcall.
>                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> Just say use MOD_FF_REG_3 and MOD_FF_REG_5.
>
> --- /dev/null
> +++ b/gas/testsuite/gas/i386/disassem.d
> @@ -0,0 +1,14 @@
> +#objdump: -drw
> +#name: ljmp and lcall with invalid modrm byte
>              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> Change it to opcodes with invalid modrm byte.
>
> +++ b/gas/testsuite/gas/i386/x86-64-disassem.d
> @@ -0,0 +1,14 @@
> +#objdump: -drw
> +#name: ljmp and lcall with invalid modrm byte
>               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> Change it to x86-64 opcodes with invalid modrm byte.
>
> +++ b/gas/testsuite/gas/i386/disassem.s
> @@ -0,0 +1,2 @@
>
> Add ".text".
>
> +.byte 0xFF, 0xEF
> +.byte 0xFF, 0xD8
>
> +++ b/gas/testsuite/gas/i386/x86-64-disassem.s
>
> Add ".text".
>
> @@ -0,0 +1,3 @@
> +.byte 0xFF, 0xEF
> +.byte 0xFF, 0xD8
> +
> ^^^ Remove trailing blank lines.
>
> Thanks.
>
> --
> H.J.



-- 
---
Best regards,
Michael V. Zolotukhin,
Software Engineer
Intel Corporation.

Attachment: ljmp-fix-with-test-02.patch
Description: Binary data

Follow-Ups:
- Re: [PATCH][x86] Fix for objdump internal error
  - From: Michael Zolotukhin

References:
- [PATCH][x86] Fix for objdump internal error
  - From: Michael Zolotukhin
- Re: [PATCH][x86] Fix for objdump internal error
  - From: H.J. Lu
- Re: [PATCH][x86] Fix for objdump internal error
  - From: Michael Zolotukhin
- Re: [PATCH][x86] Fix for objdump internal error
  - From: H.J. Lu

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]