This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [gold] PATCH: Add R_X86_64_PC32_BND and R_X86_64_PLT32_BND
- From: Cary Coutant <ccoutant at google dot com>
- To: "H.J. Lu" <hjl dot tools at gmail dot com>, Ian Lance Taylor <iant at google dot com>
- Cc: Binutils <binutils at sourceware dot org>
- Date: Fri, 22 Nov 2013 14:11:53 -0800
- Subject: Re: [gold] PATCH: Add R_X86_64_PC32_BND and R_X86_64_PLT32_BND
- Authentication-results: sourceware.org; auth=none
- References: <20131117165613 dot GA17622 at intel dot com> <20131117183518 dot GA5067 at intel dot com>
On Sun, Nov 17, 2013 at 10:35 AM, H.J. Lu <hongjiu.lu@intel.com> wrote:
> +if DEFAULT_TARGET_X86_64
> +check_PROGRAMS += exception_x86_64_bnd_test
> +exception_x86_64_bnd_test_SOURCES = exception_test_main.cc
> +exception_x86_64_bnd_test_DEPENDENCIES = exception_x86_64_bnd_1.o \
> + exception_x86_64_bnd_2.o
> +exception_x86_64_bnd_test_LDFLAGS = $(exception_test_LDFLAGS)
> +exception_x86_64_bnd_test_LDADD = $(exception_x86_64_bnd_test_DEPENDENCIES)
> +exception_x86_64_bnd_1.o: exception_test_1.cc
> + $(CXXCOMPILE) -c -fpic -Bgcctestdir/ -Wa,-madd-bnd-prefix -o $@ >lt;
> +exception_x86_64_bnd_2.o: exception_test_2.cc
> + $(CXXCOMPILE) -c -Bgcctestdir/ -Wa,-madd-bnd-prefix -o $@ >lt;
> +endif DEFAULT_TARGET_X86_64
The -madd-bnd-prefix option only works with a very recent assembler.
These last two rules should have gcctestdir/as as a dependency so that
the compiles will pick up the in-tree assembler. Alternatively, we
could add a configure check for the -madd-bnd-prefix option, and make
this test case conditional. I'd prefer the former -- your thoughts?
-cary