This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH]: XCOFF : Ensure .text/.data file offset == vma % pagesize
- From: Richard Sandiford <rsandifo at linux dot vnet dot ibm dot com>
- To: Tristan Gingold <gingold at adacore dot com>
- Cc: "binutils\ at sourceware dot org Development" <binutils at sourceware dot org>
- Date: Tue, 30 Jul 2013 15:39:41 +0100
- Subject: Re: [PATCH]: XCOFF : Ensure .text/.data file offset == vma % pagesize
- References: <229C7776-28F5-4D9F-9375-E5CE2AB0A3BE at adacore dot com>
Hi Tristan,
Sorry for the slow reply. (Seem to be saying that a lot lately.)
I was a bit surprised that we didn't have the reloc counts more easily
available, but I see what you mean.
Tristan Gingold <gingold@adacore.com> writes:
> + if (info->strip != strip_all)
> + {
> + /* There can be additional sections just for dealing with overflow in
> + reloc and lineno counts. But the numbers of relocs and lineno aren't
> + known zhen bfd_sizeof_headers is called, so we compute them by
Typo: s/zhen/when/.
> + summing the numbers from input sections. */
> + struct nbr_reloc_lineno
> + {
> + unsigned int nbr_relocs;
> + unsigned int nbr_lineno;
> + };
Very minor, sorry, but I think the code would be easier to follow if these
two fields had the same name as the thing they're summing (reloc_count
and lineno_count).
OK with those changes, thanks. Good spot!
Richard