This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH, i386] Support of SHA ISA extension
- From: "H.J. Lu" <hjl dot tools at gmail dot com>
- To: Kirill Yukhin <kirill dot yukhin at gmail dot com>
- Cc: Binutils <binutils at sourceware dot org>, areg dot melikadamyan at gmail dot com
- Date: Thu, 25 Jul 2013 09:20:17 -0700
- Subject: Re: [PATCH, i386] Support of SHA ISA extension
- References: <51EFCDD3 dot 9060403 at gmail dot com> <CAMe9rOp4amrbeVkn_pN3CC7ARHbY1TwFVR-GwuK3TtAoE8VPDg at mail dot gmail dot com> <20130725155641 dot GA61624 at msticlxl57 dot ims dot intel dot com>
On Thu, Jul 25, 2013 at 8:56 AM, Kirill Yukhin <kirill.yukhin@gmail.com> wrote:
> Hello HJ,
> Thanks for inputs.
> Attached rebased patch and patch to fix ChangeLog for MPX checkin.
>
> Coould you pls take a look?
>
> gas/Changelog:
> 2013-07-19 Michael Zolotukhin <michael.v.zolotukhin@intel.com>
>
> * config/tc-i386.c (cpu_arch): Add .sha.
> * doc/c-i386.texi: Document sha/.sha.
>
> gas/testsuite/Changelog:
> 2013-07-19 Michael Zolotukhin <michael.v.zolotukhin@intel.com>
>
> * gas/i386/sha.d: New.
> * gas/i386/sha.s: New.
> * gas/i386/x86-64-sha.d: New.
> * gas/i386/x86-64-sha.s: New.
> * gas/i386/i386.exp: Run new SHA tests.
>
> opcodes/Changelog:
> 2013-07-19 Michael Zolotukhin <michael.v.zolotukhin@intel.com>
>
> * i386-dis.c (PREFIX enum): Add PREFIX_0F38C8, PREFIX_0F38C9,
> PREFIX_0F38CA, PREFIX_0F38CB, PREFIX_0F38CC, PREFIX_0F38CD,
> PREFIX_0F3ACC.
> (prefix_table): Add new entries.
I changed it to (prefix_table): Updated. since there are
no new entries in three_byte_table.
> (three_byte_table): Likewise.
> * i386-gen.c (cpu_flag_init): Add CpuSHA.
I changed it to (cpu_flag_init): Add CPU_SHA_FLAGS. since
CpuSHA is just one bit in a CPU_XXX_FLAGS, which can have
more than one bit.
> (cpu_flags): Add CpuSHA.
> (i386_cpu_flags): Add cpusha.
> * i386-init.h: Regenerate.
> * i386-opc.h (CpuSHA): New.
I added:
(CpuUnused): Restored.
(i386_cpu_flags): Add cpusha.
> * i386-opc.tbl: Add SHA instructions.
> * i386-tbl.h: Regenerate.
>
I checked in yours patches with some changes
in SHA opcodes/Changelog.
Thanks.
--
H.J.