This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: src/bfd ChangeLog coff-rs6000.c
- From: Tristan Gingold <gingold at adacore dot com>
- To: Jan-Benedict Glaw <jbglaw at lug-owl dot de>
- Cc: Tristan Gingold <gingold at adacore dot com>, binutils at sourceware dot org
- Date: Tue, 2 Jul 2013 14:59:10 +0200
- Subject: Re: src/bfd ChangeLog coff-rs6000.c
- References: <20130702073439 dot 5726 dot qmail at sourceware dot org> <20130702124500 dot GT5610 at lug-owl dot de>
On Jul 2, 2013, at 2:45 PM, Jan-Benedict Glaw <jbglaw@lug-owl.de> wrote:
> Hi Tristan!
>
> On Tue, 2013-07-02 07:34:39 +0000, gingold@sourceware.org <gingold@sourceware.org> wrote:
>> Log message:
>> 2013-07-02 Tristan Gingold <gingold@adacore.com>
>>
>> * coff-rs6000.c (xcoff_find_nearest_line_discriminator): New function.
>> (rs6000coff_vec): Reference it.
>>
>> Patches:
>> http://sourceware.org/cgi-bin/cvsweb.cgi/src/bfd/ChangeLog.diff?cvsroot=src&r1=1.6094&r2=1.6095
>> http://sourceware.org/cgi-bin/cvsweb.cgi/src/bfd/coff-rs6000.c.diff?cvsroot=src&r1=1.109&r2=1.110
>
> This led to:
>
> /bin/bash ./libtool --tag=CC --mode=compile gcc -DHAVE_CONFIG_H -I. -I../../../../binutils/bfd -I. -I../../../../binutils/bfd -I../../../../binutils/bfd/../include -DHAVE_bfd_elf32_powerpc_vec -DHAVE_rs6000coff_vec -DHAVE_bfd_elf32_powerpcle_vec -DHAVE_ppcboot_vec -DHAVE_bfd_elf32_little_generic_vec -DHAVE_bfd_elf32_big_generic_vec -DBINDIR='"/home/vaxbuild/_install_/powerpc-linux/bin"' -W -Wall -Wstrict-prototypes -Wmissing-prototypes -Wshadow -Werror -g -O2 -MT coff-rs6000.lo -MD -MP -MF .deps/coff-rs6000.Tpo -c -o coff-rs6000.lo ../../../../binutils/bfd/coff-rs6000.c
> libtool: compile: gcc -DHAVE_CONFIG_H -I. -I../../../../binutils/bfd -I. -I../../../../binutils/bfd -I../../../../binutils/bfd/../include -DHAVE_bfd_elf32_powerpc_vec -DHAVE_rs6000coff_vec -DHAVE_bfd_elf32_powerpcle_vec -DHAVE_ppcboot_vec -DHAVE_bfd_elf32_little_generic_vec -DHAVE_bfd_elf32_big_generic_vec -DBINDIR=\"/home/vaxbuild/_install_/powerpc-linux/bin\" -W -Wall -Wstrict-prototypes -Wmissing-prototypes -Wshadow -Werror -g -O2 -MT coff-rs6000.lo -MD -MP -MF .deps/coff-rs6000.Tpo -c ../../../../binutils/bfd/coff-rs6000.c -o coff-rs6000.o
> ../../../../binutils/bfd/coff-rs6000.c:453:1: error: return type defaults to ‘int’ [-Werror=return-type]
> ../../../../binutils/bfd/coff-rs6000.c:453:1: error: no previous prototype for ‘xcoff_find_nearest_line_discriminator’ [-Werror=missing-prototypes]
> cc1: all warnings being treated as errors
> make[4]: *** [coff-rs6000.lo] Error 1
> make[4]: Leaving directory `/home/vaxbuild/build/powerpc-linux/binutils/bfd'
> make[3]: *** [all-recursive] Error 1
> make[3]: Leaving directory `/home/vaxbuild/build/powerpc-linux/binutils/bfd'
> make[2]: *** [all] Error 2
> make[2]: Leaving directory `/home/vaxbuild/build/powerpc-linux/binutils/bfd'
> make[1]: *** [all-bfd] Error 2
> make[1]: Leaving directory `/home/vaxbuild/build/powerpc-linux/binutils'
>
> for a powerpc-linux targeted build on my compile robot.
Oops, I forgot a line while committing. Now fixed.
Thanks,
Tristan.
bfd/
2013-07-02 Tristan Gingold <gingold@adacore.com>
* coff-rs6000.c (xcoff_find_nearest_line_discriminator): Add missing
line.
Index: coff-rs6000.c
===================================================================
RCS file: /cvs/src/src/bfd/coff-rs6000.c,v
retrieving revision 1.111
diff -c -r1.111 coff-rs6000.c
*** coff-rs6000.c 2 Jul 2013 07:38:51 -0000 1.111
--- coff-rs6000.c 2 Jul 2013 12:57:40 -0000
***************
*** 450,455 ****
--- 450,456 ----
line_ptr);
}
+ static bfd_boolean
xcoff_find_nearest_line_discriminator (bfd *abfd,
asection *section,
asymbol **symbols,