This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
RE: [PATCH] MIPS EVA ASE Support
- From: "Moore, Catherine" <Catherine_Moore at mentor dot com>
- To: "Rozycki, Maciej" <Maciej_Rozycki at mentor dot com>
- Cc: Richard Sandiford <rdsandiford at googlemail dot com>, "binutils at sourceware dot org" <binutils at sourceware dot org>
- Date: Tue, 18 Jun 2013 12:55:23 +0000
- Subject: RE: [PATCH] MIPS EVA ASE Support
- References: <FD3DCEAC5B03E9408544A1E416F11242F8FC6EE7 at NA-MBX-01 dot mgc dot mentorg dot com> <87fvwz9hsg dot fsf at talisman dot default> <FD3DCEAC5B03E9408544A1E416F11242F8FC9639 at NA-MBX-01 dot mgc dot mentorg dot com> <87bo7g99yn dot fsf at talisman dot default> <FD3DCEAC5B03E9408544A1E416F11242F8FC9A3B at NA-MBX-01 dot mgc dot mentorg dot com> <87ip1l7oz9 dot fsf at talisman dot default> <FD3DCEAC5B03E9408544A1E416F11242F8FCA5F6 at NA-MBX-01 dot mgc dot mentorg dot com> <alpine dot DEB dot 1 dot 10 dot 1306121710190 dot 16287 at tp dot orcam dot me dot uk> <87sj0n5g4t dot fsf at talisman dot default> <FD3DCEAC5B03E9408544A1E416F11242F8FE593D at NA-MBX-04 dot mgc dot mentorg dot com> <87txkwo33v dot fsf at talisman dot default> <FD3DCEAC5B03E9408544A1E416F11242F8FE5993 at NA-MBX-04 dot mgc dot mentorg dot com> <alpine dot DEB dot 1 dot 10 dot 1306172347000 dot 16287 at tp dot orcam dot me dot uk>
> -----Original Message-----
> From: Maciej W. Rozycki [mailto:macro@codesourcery.com]
> Sent: Monday, June 17, 2013 7:13 PM
> To: Moore, Catherine
> Cc: Richard Sandiford; binutils@sourceware.org
> Subject: RE: [PATCH] MIPS EVA ASE Support
>
> On Mon, 17 Jun 2013, Moore, Catherine wrote:
>
> > > > RCS file: /cvs/src/src/gas/testsuite/gas/mips/mips.exp,v
> > > > retrieving revision 1.222
> > > > diff -p -u -r1.222 mips.exp
> > > > --- gas/testsuite/gas/mips/mips.exp 14 Jun 2013 13:30:28 -0000
> 1.222
> > > > +++ gas/testsuite/gas/mips/mips.exp 17 Jun 2013 20:28:48 -0000
> > > > @@ -849,6 +849,8 @@ if { [istarget mips*-*-vxworks*] } {
> > > > [mips_arch_list_matching mips64r2 \
> > > > !micromips]
> > > >
> > > > + run_dump_test_arches "eva" [mips_arch_list_matching
> > > mips32r2 !octeon]
> > >
> > > For the record, this is going to fail on ecoff, as Maciej pointed
> > > out for one of the other recent patches. I'm planning to
> > > significantly trim the amount of testing we do on ecoff though --
> > > hopefully within the week -- so let's commit this as-is.
> > >
> > > OK with those changes (or non-change in the last case), thanks.
>
> I suspect it might make sense to commit the INSN_ASE_MASK macro
> removal, which is functionally unrelated, as a separate change. Otherwise it'll
> get lost in the mass of EVA-specific changes. I won't insist on that if Richard
> disagrees though. The change looks otherwise fine to me.
>
Hi Maciej,
I committed the entire patch before reading your suggestion. Sorry!
Catherine