This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
RE: [MIPS] Add new virtualization instructions
- From: Chao-Ying Fu <Chao-Ying dot Fu at imgtec dot com>
- To: "'Maciej W. Rozycki'" <macro at codesourcery dot com>
- Cc: "'Pinski, Andrew'" <Andrew dot Pinski at caviumnetworks dot com>, 'Richard Sandiford' <rdsandiford at googlemail dot com>, "binutils at sourceware dot org" <binutils at sourceware dot org>
- Date: Thu, 13 Jun 2013 20:27:59 +0000
- Subject: RE: [MIPS] Add new virtualization instructions
- References: <e790fa722ba34ff097a964d1dfa06e9d at BY2PR07MB058 dot namprd07 dot prod dot outlook dot com> <87wqr81o3b dot fsf at sandifor-thinkpad dot stglab dot manchester dot uk dot ibm dot com> <98cba9069a7141f399456267fe33b95f at BY2PR07MB058 dot namprd07 dot prod dot outlook dot com> <87d2szptbr dot fsf at sandifor-thinkpad dot stglab dot manchester dot uk dot ibm dot com>,<81D57523CB07B24881D63DE650C6ED82EDBB9B at bamail02 dot ba dot imgtec dot org> <bd8d0ebef46949869722652cd2cab2d1 at BY2PR07MB058 dot namprd07 dot prod dot outlook dot com> <81D57523CB07B24881D63DE650C6ED82018D3FE3 at BADAG02 dot ba dot imgtec dot org> <alpine dot DEB dot 1 dot 10 dot 1306130105100 dot 16287 at tp dot orcam dot me dot uk> <81D57523CB07B24881D63DE650C6ED82018D4A32 at BADAG02 dot ba dot imgtec dot org> <alpine dot DEB dot 1 dot 10 dot 1306131847410 dot 16287 at tp dot orcam dot me dot uk>
Maciej W. Rozycki wrote:
> Thanks, I can see what you mean now -- essentially VIRT64 is
> the first
> strictly microMIPS64 feature we're going to support. The
> issue looks to
> me like the outcome of a previous decision to make -mips3
> switch microMIPS
> assembly into the 64-bit mode. I believe this was your own
> decision too,
> :) that we accepted. I think we can stick to it and just as
> we already
> enable all the optional microMIPS32 features for -mips1
> assembly we do the
> same for microMIPS64 and -mips3 assembly.
>
> Given the above how about:
>
> #define ISA_SUPPORTS_VIRT64_ASE (mips_opts.isa == ISA_MIPS64R2
> || (mips_opts.micromips
> && ISA_HAS_64BIT_REGS
> (mips_opts.isa)))
>
> ? We'll then do the same if e.g. DSP64 is added to the microMIPS
> instruction set.
I am ok with your proposal. Let Richard and others respond, as Richard
approved my first patch already.
Thanks!
Regards,
Chao-ying