This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH] aarch64: Add support for GNU indirect functions.
- From: Will Newton <will dot newton at linaro dot org>
- To: Yufeng Zhang <Yufeng dot Zhang at arm dot com>
- Cc: "binutils at sourceware dot org" <binutils at sourceware dot org>, "patches at linaro dot org" <patches at linaro dot org>
- Date: Mon, 10 Jun 2013 19:04:04 +0100
- Subject: Re: [PATCH] aarch64: Add support for GNU indirect functions.
- References: <51AC5293 dot 20101 at linaro dot org> <51B60AA8 dot 2030304 at arm dot com>
On 10 June 2013 18:19, Yufeng Zhang <Yufeng.Zhang@arm.com> wrote:
> On 06/03/13 09:23, Will Newton wrote:
>>
>> +/* Find and/or create a hash entry for local symbol. */
>> +
>> +static struct elf_link_hash_entry *
>> +elf_aarch64_get_local_sym_hash (struct elf64_aarch64_link_hash_table
>> *htab,
>> + bfd *abfd, const Elf_Internal_Rela *rel,
>> + bfd_boolean create)
>> +{
>> + struct elf64_aarch64_link_hash_entry e, *ret;
>> + asection *sec = abfd->sections;
>> + hashval_t h = ELF_LOCAL_SYMBOL_HASH (sec->id,
>> + ELF32_R_SYM (rel->r_info));
>> + void **slot;
>> +
>> + e.root.indx = sec->id;
>> + e.root.dynstr_index = ELF32_R_SYM (rel->r_info);
>
>
> Sorry for the late comment, but are you sure that ELF64_R_SYM is not the one
> that you intend to use?
Thanks for noticing! I'll post a patch.
--
Will Newton
Toolchain Working Group, Linaro