Re: [PATCH] VAX/BFD: Correct GOT/PLT refcounts for static links

[Jan-Benedict Glaw <jbglaw at lug-owl dot de>]

On Mon, 2013-05-20 02:56:37 +0100, Maciej W. Rozycki <macro@linux-mips.org> wrote:
> 2013-05-20  Maciej W. Rozycki  <macro@linux-mips.org>
> 
> 	* elf32-vax.c (elf_vax_discard_got_entries): New function.
> 	(elf_vax_always_size_sections): Likewise.
> 	(elf_vax_size_dynamic_sections): Remove code moved to 
> 	elf_vax_always_size_sections.  Make comment on
> 	elf_vax_instantiate_got_entries match reality.
> 	(elf_vax_instantiate_got_entries): Assert that rather than check
> 	if dynobj is null.  Don't check for dynamic_sections_created.
> 	Make function description match reality.
> 	(elf_backend_always_size_sections): New macro.

Ok.

> --- binutils-2.23.1.orig/bfd/elf32-vax.c
> +++ binutils-2.23.1/bfd/elf32-vax.c
> @@ -1046,6 +1046,59 @@ elf_vax_adjust_dynamic_symbol (struct bf
[...]
> +static bfd_boolean
> +elf_vax_always_size_sections (bfd *output_bfd ATTRIBUTE_UNUSED,
> +			      struct bfd_link_info *info)
> +{
> +  bfd *dynobj;
> +  asection *s;
> +
> +  dynobj = elf_hash_table (info)->dynobj;
> +
> +  if (dynobj && !elf_hash_table (info)->dynamic_sections_created)
> +    {
> +      /* We may have created entries in the .rela.got and .got sections.
> +	 However, if we are not creating the dynamic sections, we will
> +	 not actually use these entries.  Reset the size of .rela.got
> +	 and .got, which will cause it to get stripped from the output

"them"?

MfG, JBG

-- 
      Jan-Benedict Glaw      jbglaw@lug-owl.de              +49-172-7608481
  Signature of:                          Zensur im Internet? Nein danke!
  the second  :

Attachment: signature.asc
Description: Digital signature