This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [GOLD] debug_msg test

From: Cary Coutant <ccoutant at google dot com>
To: Ian Lance Taylor <iant at google dot com>, Alan Modra <amodra at gmail dot com>
Cc: Binutils <binutils at sourceware dot org>
Date: Tue, 16 Apr 2013 15:29:40 -0700
Subject: Re: [GOLD] debug_msg test
References: <20130306115951 dot GL562 at bubble dot grove dot modra dot org> <CAKOQZ8xMVCJ-YO+f8Chj-=3AXkBNk9DkZu5jK_cGg7jHtwsaHw at mail dot gmail dot com> <CAHACq4oD9_OAP1a=K8+OBiLdutagO_eFagHd1q-O-870O6NpHg at mail dot gmail dot com> <20130306235910 dot GR562 at bubble dot grove dot modra dot org> <CAHACq4qYXmJ8SnuDfgHkhDLNEPn0RfwtQ6NNbDeAy5r0pvRNBg at mail dot gmail dot com> <CAKOQZ8ybNQLknO=h0kH7Q7jh6XJQDtQOwvpihfa2pij81YZV0w at mail dot gmail dot com> <CAHACq4pGbMEAXR-0n+gFyrqqNXHy1hSNbkrFtgjHjgn9nV7eoA at mail dot gmail dot com> <CAKOQZ8x_cJc_+J8mnD2mDOJP0tS8R1z4tamYs6UsEbGW1D96kw at mail dot gmail dot com>

>>> First, I think it would be simpler to set DEFAULT_TARGET in
>>> configure.ac and AC_SUBST it in configure.ac.  After the
>>> AM_CONDITIONAL lines setting DEFAULT_TARGET_ARM and friends:
>>>     DEFAULT_TARGET=${targ_obj}
>>>     AC_SUBST(DEFAULT_TARGET)
>>>
>>> Then after you run autoreconf DEFAULT_TARGET will be set in
>>> testsuite/Makefile.am.
>>>
>>> To get it into the environment, add this to testsuite/Makefile.am:
>>>
>>> .EXPORT_ALL_VARIABLES:

Here's an updated patch. I've verified that it *does* run the check
for undef_int on x86_64, and that it actually does see the right value
for $DEFAULT_TARGET. Alan, can you double-check this on PPC?

-cary


gold/
    * configure.ac: Export DEFAULT_TARGET.
    * configure: Regenerate.
    * Makefile.in: Regenerate.
    * testsuite/Makefile.am: Add .EXPORT_ALL_VARIABLES.
    * testsuite/Makefile.in: Regenerate.
    * testsuite/debug_msg.sh: Delete duplicate tests.
    Don't check undef_int error message match for powerpc where the
    source file and line number aren't available.

Attachment: gold-debug-msg-ppc-patch-2.txt
Description: Text document

Follow-Ups:
- Re: [GOLD] debug_msg test
  - From: Alan Modra

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]