Re: [Patch, ARM/AArch64] Add new elf note types

[Richard Earnshaw <rearnsha at arm dot com>]

On 08/01/13 16:48, Yufeng Zhang wrote:
> Hi,
>
> Please find the updated patch and change log which have incorporated
> changes discussed offline.
>
> Is it OK to commit?
>
> Thanks,
> Yufeng

Ok, but,

> --- a/include/elf/common.h
> +++ b/include/elf/common.h
> @@ -552,6 +552,15 @@
>   #define NT_S390_SYSTEM_CALL     0x307   /* S390 system call restart data */
>   					/*   note name must be "LINUX".  */
>   #define NT_ARM_VFP	0x400		/* ARM VFP registers */
> +#define NT_ARM_TLS	0x401		/* AArch TLS registers */
> +					/*   note name must be "LINUX".  */
> +					/* This and the following two
> +					   definitions should really be
> +					   NT_AARCH_..., but defined this way
> +					   for compatibility with Linux.  */

Please put this comment before the definition of NT_ARM_TLS, and change 
it to:

/* The following definitions should really use ...

R.

> +#define NT_ARM_HW_BREAK	0x402		/* AArch hardware breakpoint registers */
> +					/*   note name must be "LINUX".  */
> +#define NT_ARM_HW_WATCH	0x403		/* AArch hardware watchpoint registers */
>   					/*   note name must be "LINUX".  */
>   #define NT_SIGINFO	0x53494749	/* Fields of siginfo_t.  */
>   #define NT_FILE		0x46494c45	/* Description of mapped files.  */