This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |
Other format: | [Raw text] |
On 11/28/2012 10:16 PM, David Holsgrove wrote:Hi Michael,
-----Original Message----- From: Michael Eager [mailto:eager@eagerm.com] Sent: Thursday, 29 November 2012 5:15 am To: David Holsgrove Cc: binutils@sourceware.org; John Williams; Vinod Kathail; Tom Shui; Vidhumouli Hunsigida; Nagaraju Mekala; Edgar E. Iglesias Subject: Re: [Patch, microblaze, gas, opcodes] Change insn type INST_TYPE_RD_R1_SPECIAL -> INST_TYPE_R1_R2_SPECIAL
On 11/22/2012 04:04 AM, David Holsgrove wrote:
Change write to data cache and write to instruction cache insns to be of type INST_TYPE_R1_R2_SPECIAL (currently INST_TYPE_RD_R1_SPECIAL)
Is this patch only renaming INST_TYPE_RD_R1_SPECIAL to INST_TYPE_R1_R2_SPECIAL other than the following change?
/* insn wic ra, rb => wic ra, ra, rb. */ - inst |= (reg1 << RD_LOW) & RD_MASK; inst |= (reg1 << RA_LOW) & RA_MASK; inst |= (reg2 << RB_LOW) & RB_MASK;
I don't see changes to wdc* instructions.
Thanks for the review - yes this patch is renaming INST_TYPE_RD_R1_SPECIAL to INST_TYPE_R1_R2_SPECIAL, and then in opcodes/microblaze-opc.h we switch the instructions wic, wdc* to use this newly defined type.
I'll commit with this ChangeLog:
binutils/opcodes/Changelog
2012-11-22 David Holsgrove <david.holsgrove@xilinx.com>
* microblaze-opc.h: Rename INST_TYPE_RD_R1_SPECIAL to INST_TYPE_R1_R2_SPECIAL * microblaze-dis.c (print_insn_microblaze): Same.
binutils/gas/Changelog
2012-11-22 David Holsgrove <david.holsgrove@xilinx.com>
* gas/config/tc-microblaze.c: Rename INST_TYPE_RD_R1_SPECIAL to INST_TYPE_R1_R2_SPECIAL, don't set RD for wic.
-- Michael Eager eager@eagercon.com 1960 Park Blvd., Palo Alto, CA 94306 650-325-8077
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |