This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: PATCH: PR ld/14591: Wrong symbol type with common symbol and weak function
On Tue, Sep 18, 2012 at 4:32 PM, Alan Modra <amodra@gmail.com> wrote:
> On Tue, Sep 18, 2012 at 07:21:16AM -0700, H.J. Lu wrote:
>> Here is the updated patch with additinal tests. OK to install?
>
> OK.
>
I also checked in this patch. Otherwise, --enable-targets=all fails
to compile.
--
H.J.
--
* elf32-sh-symbian.c (sh_symbian_relocate_section): Update
_bfd_elf_merge_symbol call.
diff --git a/bfd/elf32-sh-symbian.c b/bfd/elf32-sh-symbian.c
index 0882d52..1f03dbc 100644
--- a/bfd/elf32-sh-symbian.c
+++ b/bfd/elf32-sh-symbian.c
@@ -497,7 +497,7 @@ sh_symbian_relocate_section (bfd * output_b
fd,
if (! _bfd_elf_merge_symbol (input_bfd, info,
ptr->new_name, & new_sym,
& psec, & new_value, NULL,
- & new_hash, & skip,
+ NULL, & new_hash, & skip,
& override, & type_change_ok,
& size_change_ok))
{