This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH] MIPS: Opcode membership proposal
- From: "Maciej W. Rozycki" <macro at codesourcery dot com>
- To: Richard Sandiford <rdsandiford at googlemail dot com>
- Cc: David Daney <ddaney at caviumnetworks dot com>, Andrew Pinski <andrew dot pinski at caviumnetworks dot com>, <binutils at sourceware dot org>
- Date: Mon, 13 Aug 2012 15:43:20 +0100
- Subject: Re: [PATCH] MIPS: Opcode membership proposal
- References: <alpine.DEB.1.10.1012181108290.4142@tp.orcam.me.uk> <alpine.DEB.1.10.1110311233290.28657@tp.orcam.me.uk> <87obway4f5.fsf@firetop.home> <alpine.DEB.1.10.1208092012040.20608@tp.orcam.me.uk> <87zk60t0zd.fsf@talisman.home>
On Sun, 12 Aug 2012, Richard Sandiford wrote:
> > Hmm, where's the typo? That's supposed to be true as long as the CPU is
> > other than Octeon or the Octeon exclusion bit is zero. Did I get that
> > wrong?
>
> The typo is in the last line I quoted:
>
> >> > + && ((cpu != CPU_OCTEON || ((insn)->exclusions & CPU_OCTEON) == 0)
> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
>
> CPU_OCTEON is an enum value (6501), not a bitmask value. As I say,
> it looked like it should be "((insn)->exclusions & INSN_OCTEON) == 0"
> instead.
Awww!
> Patch is OK.
And now in, thanks.
Maciej