This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] MIPS: Enable NewABI testing for all Linux targets


On Tue, 7 Aug 2012, Richard Sandiford wrote:

> >> Not including the targets in the BFD64 block at the time that the
> >> extra vectors were added was probably an oversight.
> >
> >  I've been wondering if these extra vectors were added by mistake instead, 
> > like slipped through in a larger commit unnoticed.  I'll post a fix to the 
> > BFD64 block separately.
> 
> The 64-bit ones?  No, Debian wanted to allow 32-bit *-linux-gnu targets
> that provice all three ABIs, while still defaulting to o32.  The associated
> GCC configure option is --enable-targets=all.  (Confusingly different from
> the binutils meaning, but there you go.  That choice of name wasn't a MIPS
> invention.)

 OK, thanks for this background information.  Here's the change I 
promised, no regressions on the 23 MIPS targets.  OK to apply?

  Maciej

2012-08-10  Maciej W. Rozycki  <macro@codesourcery.com>

	bfd/
	* config.bfd: Wrap mips*-*-linux* and mips*el-*-linux* into
	#ifdef BFD64.

binutils-bfd64-mips-linux.diff
Index: binutils-fsf-trunk-quilt/bfd/config.bfd
===================================================================
--- binutils-fsf-trunk-quilt.orig/bfd/config.bfd	2012-07-04 12:07:36.000000000 +0100
+++ binutils-fsf-trunk-quilt/bfd/config.bfd	2012-08-06 22:49:09.591194507 +0100
@@ -1005,7 +1005,6 @@ case "${targ}" in
     targ_selvecs="bfd_elf32_ntradlittlemips_vec bfd_elf32_tradbigmips_vec bfd_elf32_tradlittlemips_vec bfd_elf64_tradbigmips_vec bfd_elf64_tradlittlemips_vec"
     want64=true
     ;;
-#endif
   mips*el-*-linux*)
     targ_defvec=bfd_elf32_tradlittlemips_vec
     targ_selvecs="bfd_elf32_tradbigmips_vec ecoff_little_vec ecoff_big_vec bfd_elf32_ntradlittlemips_vec bfd_elf64_tradlittlemips_vec bfd_elf32_ntradbigmips_vec bfd_elf64_tradbigmips_vec"
@@ -1016,7 +1015,6 @@ case "${targ}" in
     targ_selvecs="bfd_elf32_tradlittlemips_vec ecoff_big_vec ecoff_little_vec bfd_elf32_ntradbigmips_vec bfd_elf64_tradbigmips_vec bfd_elf32_ntradlittlemips_vec bfd_elf64_tradlittlemips_vec"
     want64=true
     ;;
-#ifdef BFD64
   mips64*el-*-freebsd* | mips64*el-*-kfreebsd*-gnu)
     # FreeBSD vectors
     targ_defvec=bfd_elf32_ntradlittlemips_freebsd_vec


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]