This is the mail archive of the mailing list for the binutils project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 1/4] LD: Linker script hidden symbol support

On Sat, 4 Aug 2012, Alan Modra wrote:

> >
> > 
> > switched the scope of symbols created in linker scripts from object to 
> > global.
> Not so.  The above patch did not change the scope of symbols created
> in linker scripts.  What it did do is change some linker created
> symbols to instead be created by PROVIDE in the linker script, and
> shortly thereafter this was corrected to PROVIDE_HIDDEN.  Linker
> script symbols have been global forever.

 Hmm, I must have misinterpreted the change then, sorry about that.

> >  The original change also broke all MIPS SVR4 ABI binaries produced as 
> > with the switch from the object to the global scope the required _gp 
> > symbol was no longer defined such as the MIPS psABI mandated.
> So the above change can't have been responsible for breaking MIPS..

 I have now checked some old MIPS/Linux binaries I have lurking around and 
_gp appears exported in some back to 2001; those from 2000 do not have the 
symbol in the dynamic table.  Obviously having access to main executable's 
value of GP in shared libraries rather than their own is less than useful 
> Regardless of that, I like the patch.  Please commit.

 I have done so now, thanks for the review.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]