This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH] MIPS: 32-bit microMIPS DSP ASE support
- From: "Maciej W. Rozycki" <macro at codesourcery dot com>
- To: Alan Modra <amodra at gmail dot com>
- Cc: Richard Sandiford <rdsandiford at googlemail dot com>, <binutils at sourceware dot org>, Catherine Moore <clm at codesourcery dot com>, Chao-ying Fu <fu at mips dot com>
- Date: Wed, 1 Aug 2012 02:25:40 +0100
- Subject: Re: [PATCH] MIPS: 32-bit microMIPS DSP ASE support
- References: <alpine.DEB.1.10.1110252323030.28657@tp.orcam.me.uk> <87fwhdrzn3.fsf@firetop.home> <alpine.DEB.1.10.1207310330430.19403@tp.orcam.me.uk> <20120801004216.GV3182@bubble.grove.modra.org>
On Wed, 1 Aug 2012, Alan Modra wrote:
> In future, please compile your code with both 32-bit and 64-bit
> compilers before committing. Your ChangeLog entry was wrong too.
I didn't run `quilt refresh' to regenerate the patch, sorry about that --
you can see I meant to drop the "l" modifier and code was indeed tested
with that update already made. I also used an outdated version of
ChangeLog, I'll fix that up as follows -- what's the convention for CVS
log entries for ChangeLog corrections?
Maciej
Index: gas/ChangeLog
===================================================================
RCS file: /cvs/src/src/gas/ChangeLog,v
retrieving revision 1.4777
diff -u -p -r1.4777 ChangeLog
--- gas/ChangeLog 31 Jul 2012 21:38:53 -0000 1.4777
+++ gas/ChangeLog 1 Aug 2012 01:21:36 -0000
@@ -2,7 +2,10 @@
Chao-Ying Fu <fu@mips.com>
Catherine Moore <clm@codesourcery.com>
- * config/tc-mips.c (macro_build) <'2'>: Handle microMIPS.
+ * config/tc-mips.c (ISA_SUPPORTS_DSP_ASE): Also set if microMIPS
+ mode.
+ (ISA_SUPPORTS_DSPR2_ASE): Likewise.
+ (macro_build) <'2'>: Handle microMIPS.
(macro) <M_BALIGN>: Update error handling.
(validate_micromips_insn) <'2', '3', '4', '5', '6'>: New cases.
<'7', '8', '0', '@', '^'>: Likewise.
Index: gas/testsuite/ChangeLog
===================================================================
RCS file: /cvs/src/src/gas/testsuite/ChangeLog,v
retrieving revision 1.2062
diff -u -p -r1.2062 ChangeLog
--- gas/testsuite/ChangeLog 31 Jul 2012 21:38:53 -0000 1.2062
+++ gas/testsuite/ChangeLog 1 Aug 2012 01:21:36 -0000
@@ -1,12 +1,14 @@
2012-07-31 Catherine Moore <clm@codesourcery.com>
Maciej W. Rozycki <macro@codesourcery.com>
- * gas/mips/micromips@mips32-dsp.d: New.
- * gas/mips/micromips@mips32-dspr2.d: New.
+ * gas/mips/micromips@mips32-dsp.d: New test.
+ * gas/mips/micromips@mips32-dspr2.d: New test.
* gas/mips/mips32-dsp.d: Remove -mips32r2.
* gas/mips/mips32-dspr2.d: Likewise.
- * gas/mips/mips.exp: (mips_create_arch): Use -mips64r2
- for micromips. Use run_dump_test_arches to run dsp tests.
+ * gas/mips/mips32-dsp.s: Update padding.
+ * gas/mips/mips32-dspr2.s: Likewise.
+ * gas/mips/mips.exp: Use run_dump_test_arches to run MIPS32 DSP
+ tests.
2012-07-31 H.J. Lu <hongjiu.lu@intel.com>
Index: opcodes/ChangeLog
===================================================================
RCS file: /cvs/src/src/opcodes/ChangeLog,v
retrieving revision 1.1837
diff -u -p -r1.1837 ChangeLog
--- opcodes/ChangeLog 1 Aug 2012 00:41:34 -0000 1.1837
+++ opcodes/ChangeLog 1 Aug 2012 01:21:44 -0000
@@ -19,7 +19,7 @@
(DSP_VOLA): Likewise.
(D32, D33): Likewise.
(micromips_opcodes): Add DSP ASE instructions.
- * mips-dis.c (print_insn_micromips) <'2', '3'>: New cases.
+ * micromips-dis.c (print_insn_micromips) <'2', '3'>: New cases.
<'4', '5', '6', '7', '8', '0', '^', '@'>: Likewise.
2012-07-31 Jan Beulich <jbeulich@suse.com>