This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH] x86 gas: allow 'rep nop'
- From: "H.J. Lu" <hjl dot tools at gmail dot com>
- To: Roland McGrath <mcgrathr at google dot com>
- Cc: binutils at sourceware dot org
- Date: Mon, 2 Jul 2012 10:10:30 -0700
- Subject: Re: [PATCH] x86 gas: allow 'rep nop'
- References: <x57j395af77l.fsf@frobland.mtv.corp.google.com>
On Mon, Jul 2, 2012 at 9:39 AM, Roland McGrath <mcgrathr@google.com> wrote:
> There is another 'rep;INSN' form that GCC likes to emit, this one
> 'rep;nop' as an alias for 'pause'. ?It's nicer to accept 'rep nop'
> for this one too.
>
> Ok for trunk?
>
>
> Thanks,
> Roland
>
>
> gas/testsuite/
> 2012-07-02 ?Roland McGrath ?<mcgrathr@google.com>
>
> ? ? ? ? * gas/i386/rep-nop.d: New file.
> ? ? ? ? * gas/i386/rep-nop.s: New file.
> ? ? ? ? * gas/i386/i386.exp: Add the new test.
>
> opcodes/
> 2012-07-02 ?Roland McGrath ?<mcgrathr@google.com>
>
> ? ? ? ? * i386-opc.tbl: Add RepPrefixOk to nop.
>
I checked in a patch:
http://sourceware.org/ml/binutils/2012-07/msg00019.html
to move rep tests for bsf/bsr/ret to rep-suffix. Please add the
rep nop test to both rep-suffix.s and x86-64-rep-suffix.s. OK
with this change.
Thanks.
--
H.J.