This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
[PATCH] elf32-arm: error when encountering R_ARM_TLS_LE32 in a shared object
- From: John Szakmeister <john at szakmeister dot net>
- To: binutils at sourceware dot org
- Cc: John Szakmeister <john at szakmeister dot net>
- Date: Fri, 15 Jun 2012 06:14:44 -0400
- Subject: [PATCH] elf32-arm: error when encountering R_ARM_TLS_LE32 in a shared object
- References: <1339755284-24896-1-git-send-email-john@szakmeister.net>
This appears to be a copy and paste error. In this case though, FALSE
translates into bfd_reloc_ok, which is clearly the wrong status code.
Switched to bfd_reloc_notsupported to ensure that the linker exits with
an error code instead of producing a broken binary.
---
bfd/elf32-arm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/bfd/elf32-arm.c b/bfd/elf32-arm.c
index e9157b2..826dd7e 100644
--- a/bfd/elf32-arm.c
+++ b/bfd/elf32-arm.c
@@ -9664,7 +9664,7 @@ elf32_arm_final_link_relocate (reloc_howto_type * howto,
(_("%B(%A+0x%lx): R_ARM_TLS_LE32 relocation not permitted in shared object"),
input_bfd, input_section,
(long) rel->r_offset, howto->name);
- return (bfd_reloc_status_type) FALSE;
+ return bfd_reloc_notsupported;
}
else
value = tpoff (info, value);
--
1.7.10.2