This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [gold patch]Fix gold build on MacOSX Xcode 3.2.6
- From: Andreas Schwab <schwab at linux-m68k dot org>
- To: Jing Yu <jingyu at google dot com>
- Cc: binutils at sourceware dot org, Doug Kwan <dougkwan at google dot com>, Andrew Hsieh <andrewhsieh at google dot com>
- Date: Tue, 05 Jun 2012 20:14:36 +0200
- Subject: Re: [gold patch]Fix gold build on MacOSX Xcode 3.2.6
- References: <CAJ_rGWT3KK1eXBoOhX9JUE89HR7RSPz9cVyMmt3u_vy0p6mHew@mail.gmail.com>
Jing Yu <jingyu@google.com> writes:
> The gcc 4.2.1 (Apple Inc. build 5666, dot 3) comes with Xcode 3.2.6
> emits warning for "while (0);" and breaks the build (thanks to -Werror
> which treat warning as error). Add "{}" to fix it.
>
> Gold make check passes on x86-64.
>
> 2012-06-05 Jing Yu <jingyu@google.com>
>
> * gold.h (textdomain): Add {} to empty while(0)
> (bindtextdomain): Likewise
That makes it unsafe as a statement.
Andreas.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."