This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: vle testcases
On 05/17/2012 03:04 AM, Alan Modra wrote:
More seriously, these two
failures occur on all powerpc targets.
powerpc64-linux +FAIL: VLE Simplified mnemonics 5
powerpc64-linux +FAIL: VLE Simplified mnemonics 6
This resolves the failing gas test: vle-simple-6.
OK to commit?
I will be out of the office until Thursday 05/24. I can commit these 3 recent
patches then.
Cheers, Jim.
--
Jim Lemke
Mentor Graphics / CodeSourcery
Orillia Ontario, +1-613-963-1073
2012-05-17 James Lemke <jwlemke@codesourcery.com>
* ppc-opc.c (extract_sprg): Use ALLOW8_SPRG to include VLE.
Index: opcodes/ppc-opc.c
===================================================================
RCS file: /cvs/src/src/opcodes/ppc-opc.c,v
retrieving revision 1.142
diff -u -p -r1.142 ppc-opc.c
--- opcodes/ppc-opc.c 14 May 2012 19:45:30 -0000 1.142
+++ opcodes/ppc-opc.c 17 May 2012 20:59:53 -0000
@@ -1825,8 +1825,7 @@ insert_sprg (unsigned long insn,
const char **errmsg)
{
if (value > 7
- || (value > 3
- && (dialect & ALLOW8_SPRG) == 0))
+ || (value > 3 && (dialect & ALLOW8_SPRG) == 0))
*errmsg = _("invalid sprg number");
/* If this is mfsprg4..7 then use spr 260..263 which can be read in
@@ -1844,9 +1843,9 @@ extract_sprg (unsigned long insn,
{
unsigned long val = (insn >> 16) & 0x1f;
- /* mfsprg can use 260..263 and 272..279. mtsprg only uses spr 272..279
+ /* mfsprg can use 260..263 and 272..275. mtsprg only uses spr 272..279
If not BOOKE or 405, then both use only 272..275. */
- if ((val - 0x10 > 3 && (dialect & (PPC_OPCODE_BOOKE | PPC_OPCODE_405)) == 0)
+ if ((val - 0x10 > 3 && (dialect & ALLOW8_SPRG) == 0)
|| (val - 0x10 > 7 && (insn & 0x100) != 0)
|| val <= 3
|| (val & 8) != 0)