This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH] VAX/BFD: Omit PLT slots for local symbols
- From: Hans-Peter Nilsson <hp at bitrange dot com>
- To: "Maciej W. Rozycki" <macro at linux-mips dot org>
- Cc: binutils at sourceware dot org
- Date: Tue, 8 May 2012 00:12:14 -0400 (EDT)
- Subject: Re: [PATCH] VAX/BFD: Omit PLT slots for local symbols
- References: <alpine.LFD.2.00.1205072350090.3701@eddie.linux-mips.org>
(Not a maintainer-status review.)
On Tue, 8 May 2012, Maciej W. Rozycki wrote:
> ld/testsuite/
> * ld-vax-elf/plt-local-lib.dd: New test.
> * ld-vax-elf/plt-local-lib.ld: New test linker script.
> * ld-vax-elf/plt-local-lib.s: New test source.
> * ld-vax-elf/plt-local.dd: New test.
> * ld-vax-elf/plt-local.ld:New test linker script.
> * ld-vax-elf/plt-local.s: New test source.
> * ld-vax-elf/plt-local-hidden-pic.s: New test source.
> * ld-vax-elf/plt-local-rehidden-pic.s: New test source.
> * ld-vax-elf/vax-elf.exp: New test script.
> Index: binutils/ld/testsuite/ld-vax-elf/vax-elf.exp
> ===================================================================
> --- /dev/null
> +++ binutils/ld/testsuite/ld-vax-elf/vax-elf.exp
> @@ -0,0 +1,50 @@
> +# Expect script for VAX ELF linker tests
...
> +
> +run_ld_link_tests [list \
> + [list "PLT test (shared library)" \
> + "-shared -T plt-local-lib.ld" \
> + "-k" \
> + { plt-local-lib.s } \
> + { { objdump -d plt-local-lib.dd } } \
> + "plt-local-lib.so"] \
> + [list "PLT test (object 1)" \
> + "-r" \
... (pruned for brevity)
Ouch, another one of those tables-of-lists-of-tables and in a
brand-new .exp.
Let me suggest instead using a mechanism such as run_dump_test
with depended parts (DSO's linked against) sorted before others.
This'd give easy drop-in of new tests without having to add to a
separate table entry somewhere. See ld-cris/cris.exp. Similar
new test: ld-arm/gc-hidden-1.d (unfortunately there's no
file-name iterator in arm-elf.exp, entries are still added
manually).
brgds, H-P