This is the mail archive of the mailing list for the binutils project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: gold patch committed: Build fixes for clang

On Wed, Apr 25, 2012 at 5:07 PM, Ian Lance Taylor <> wrote:
> I got a report of some warnings building gold with clang. ÂThis patch
> fixes them. ÂCommitted to mainline.

These fixes are not really needed for standard C++ compiler.
Since struct and class are interchangeable there.
I think it was a bad decision on clang's part to say they are different.

Though can you figure out why GCC does not warn/error out about the
do_is_defined_by_abi change?

Andrew Pinski

> Ian
> 2012-04-25 ÂIan Lance Taylor Â<>
> Â Â Â Â* (Target_arm::do_is_defined_by_abi): Make sym a const
> Â Â Â Âpointer.
> Â Â Â Â(Stub_addend_reader::operator()): Declare Arm_relocate_functions
> Â Â Â Âas a class, not a struct.
> Â Â Â Â(Target_arm::scan_span_for_cortex_a8_erratum): Likewise.
> Â Â Â Â(Target_arm::apply_cortex_a8_workaround): Likewise.
> Â Â Â Â* gc.h: Declare Reloc_types as a struct, not a class.
> Â Â Â Â* object.h: Declare Symbols_data as a struct.
> Â Â Â Â* reloc.h: Declare Read_relocs_data as a struct.
> Â Â Â Â* target.h: Declare Relocate_info as a struct.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]