This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH] BFD/gas support for arm-nacl target
- From: Matthew Gretton-Dann <matthew dot gretton-dann at arm dot com>
- To: Roland McGrath <mcgrathr at google dot com>
- Cc: "binutils at sourceware dot org" <binutils at sourceware dot org>, David Sehr <sehr at google dot com>
- Date: Fri, 16 Mar 2012 09:20:32 +0000
- Subject: Re: [PATCH] BFD/gas support for arm-nacl target
- References: <x57jd38uom6t.fsf@frobland.mtv.corp.google.com>
On Fri, Mar 02, 2012 at 07:08:26PM +0000, Roland McGrath wrote:
> This patch enables arm*-*-nacl* targets in BFD and gas.
> The BFD target has only the most basic settings for this variant,
> i.e. enough for the assembler alone.
>
> Much more will be needed in bfd/ for the linking-related changes, which I
> will submit later on. But this is a start, and I'd like to get it in now
> since it's enough for the assembler target.
>
> Ok for trunk?
I am not a maintainer so can't approve.
However, the code itself looks okay. The only comment I would have is that
there are probably more tests in the testsuite that should match *-*-nacl*
than just those you have enabled:
> * gas/arm/arch4t-eabi.d: Match *-*-nacl* targets too.
> * gas/arm/arch4t.d: Likewise.
> * gas/arm/got_prel.d: Likewise.
> * gas/arm/got_prel.d: Likewise.
> * gas/arm/mapdir.d: Likewise.
> * gas/arm/mapmisc.d: Likewise.
> * gas/arm/mapsecs.d: Likewise.
> * gas/arm/mapshort-eabi.d: Likewise.
> * gas/arm/mapshort-elf.d: Likewise.
> * gas/arm/thumb-eabi.d: Likewise.
> * gas/arm/thumb.d: Likewise.
> * gas/arm/thumbrel.d: Likewise.
In particular those which check that the assembler is outputting the correct
attributes (any that have a # readelf: -A line in the .d file).
Thanks,
Matt
--
Matthew Gretton-Dann
Principal Engineer, PD Software, ARM Ltd.