This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Performance issue with GNU/ld and DLL


2012/2/10 Pascal Obry <pascal@obry.net>:
>
> Kai,
>
>> So this patch seems to me not ok, as for binary-searching we need to
>> make sure list is sorted.
>
> I've reviewed the code and in fact the exports table is update by
> def_file_add_export(). This routine insert the items at the good
> location, keeping the table sorted.
>
> The only location where the table is updated without using this routine
> is in the process_def_file_and_directve line 780 in the section where @
> is removed.
>
> ?/* Canonicalize the export list. ?*/
> ?if (pe_dll_kill_ats)
>
> My patch sort the exports table only in this case and only when needed.
>
> If I have not overlooked some other update the attached patch should be ok.
>
> Comments?
>
> Pascal.

Yes, looks fine to me now.  I can't approve it, but Dave or Nick are
able to.  So I added Dave here, too.

Regards,
Kai


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]