This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [gold] PATCH: Support x32 GD->IE and GD->LE optimizations
- From: Ian Lance Taylor <iant at google dot com>
- To: "H.J. Lu" <hjl dot tools at gmail dot com>
- Cc: binutils at sourceware dot org
- Date: Fri, 27 Jan 2012 15:22:48 -0800
- Subject: Re: [gold] PATCH: Support x32 GD->IE and GD->LE optimizations
- References: <20120127223614.GA23995@intel.com>
"H.J. Lu" <hongjiu.lu@intel.com> writes:
> 2012-01-27 H.J. Lu <hongjiu.lu@intel.com>
>
> * x86_64.cc (Relocate::tls_gd_to_ie): Support x32.
> (Relocate::tls_gd_to_le): Likewise.
> + tls::check_tls(relinfo, relnum, rela.get_r_offset(),
> + (memcmp(view - 3, "\x48\x8d\x3d", 4) == 0));
The last argument to this memcmp should be 3, not 4.
> + tls::check_tls(relinfo, relnum, rela.get_r_offset(),
> + (memcmp(view - 3, "\x48\x8d\x3d", 4) == 0));
Same here.
This is OK with those changes.
Thanks.
Ian