This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [gold patch] Add inlined fast path for LEB128 routines

From: Cary Coutant <ccoutant at google dot com>
To: Ian Lance Taylor <iant at google dot com>
Cc: Binutils <binutils at sourceware dot org>
Date: Tue, 24 Jan 2012 23:37:11 -0800
Subject: Re: [gold patch] Add inlined fast path for LEB128 routines
References: <CAHACq4phYnC51NfOymtoPzmBkUcEug9_-jW2X_K_fnWqkXyM0A@mail.gmail.com> <mcry5swuypb.fsf@dhcp-172-18-216-180.mtv.corp.google.com>

>> + ?if (byte & 0x80)
>> + ? ?return read_unsigned_LEB_128_x(buffer, plen, byte);
>
> Write ((byte & 0x80) != 0)
>
>> + ?if (byte & 0x80)
>> + ? ?return read_signed_LEB_128_x(buffer, plen, byte);
>
> Here too.
>
> This is OK with those changes.

Done and committed, thanks. The patch as committed is attached...

-cary



2012-01-24  Cary Coutant  <ccoutant@google.com>

	* int_encoding.cc (read_unsigned_LEB_128): Replaced with inline
	definition and ...
	(read_unsigned_LEB_128_x): ... this new function.
	(read_signed_LEB_128): Replaced with inline definition and ...
	(read_signed_LEB_128_x): ... this new function.
	* int_encoding.h  (read_unsigned_LEB_128_x): New function.
	(read_unsigned_LEB_128): Add inline definition.
	(read_signed_LEB_128_x): New function.
	(read_signed_LEB_128): Add inline definition.
	* testsuite/Makefile.am (leb128_unittest): New unit test.
	* testsuite/Makefile.in: Regenerate.
	* testsuite/leb128_unittest.cc: New unit test.

Attachment: gold-fast-leb128-patch.txt
Description: Text document

References:
- [gold patch] Add inlined fast path for LEB128 routines
  - From: Cary Coutant
- Re: [gold patch] Add inlined fast path for LEB128 routines
  - From: Ian Lance Taylor

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]