This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [Patch]: Improve handling of DW_LNE_define_file

On 01/12/2012 04:05 AM, Tristan Gingold wrote:

index a775818..08f472f 100644
--- a/binutils/dwarf.c
+++ b/binutils/dwarf.c


@@ -288,7 +289,11 @@ process_extended_line_op (unsigned char *data, int is_stmt)
        printf ("%s\t", dwarf_vmatoa ("u", read_leb128 (data,&  bytes_read, 0)));
        data += bytes_read;
        printf ("%s\t", dwarf_vmatoa ("u", read_leb128 (data,&  bytes_read, 0)));
-      printf ("%s\n\n", name);
+      data += bytes_read;
+      printf ("%s", name);
+      if (data - orig_data != len)


This should be
         if ((unsigned int) (data - orig_data) != len)
or change len to "int".

I prefer changing len. I can check in obvious patch.


--
Michael Eager	 eager@eagercon.com
1960 Park Blvd., Palo Alto, CA 94306  650-325-8077

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]