This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: Duplicate 0x prefix - cr16 - bug. no. 10173
- From: Alan Modra <amodra at gmail dot com>
- To: James Murray <jsm at jsm-net dot demon dot co dot uk>
- Cc: binutils at sourceware dot org
- Date: Tue, 17 Jan 2012 10:22:12 +1030
- Subject: Re: Duplicate 0x prefix - cr16 - bug. no. 10173
- References: <1324919489.2430.89.camel@jsm2>
On Mon, Dec 26, 2011 at 05:11:29PM +0000, James Murray wrote:
> Regarding:
> http://sourceware.org/bugzilla/show_bug.cgi?id=10173
>
> The fix for the duplicate 0x prefix on numbers during disassembly was:
>
> --- src/opcodes/cr16-dis.c 2008/11/27 11:30:33 1.5
> +++ src/opcodes/cr16-dis.c 2009/06/15 15:24:52 1.6
> @@ -678,7 +678,9 @@
> + /* PR 10173: Avoid printing the 0x prefix twice. */
> + if (info->num_symbols > 0)
> + func (stream, "%s", "0x");
>
>
> I'm wondering if that might be better as
> + if (info->symtab_size > 0)
Applied.
--
Alan Modra
Australia Development Lab, IBM